After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697256 - Can't attach files with ":" or spaces in their names
Can't attach files with ":" or spaces in their names
Status: RESOLVED NOTGNOME
Product: epiphany
Classification: Core
Component: General
3.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 697831 702582 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-04 11:40 UTC by Bastien Nocera
Modified: 2013-07-15 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
twitter webapp (812.42 KB, image/png)
2013-04-04 11:40 UTC, Bastien Nocera
Details
test (5 bytes, application/octet-stream)
2013-07-12 06:18 UTC, Carlos Garcia Campos
Details
test (5 bytes, application/octet-stream)
2013-07-12 13:23 UTC, Michael Catanzaro
Details
test with space (5 bytes, application/octet-stream)
2013-07-12 13:55 UTC, Carlos Garcia Campos
Details
Test with spaces using patched wk stable branch (10 bytes, application/octet-stream)
2013-07-15 15:47 UTC, Carlos Garcia Campos
Details

Description Bastien Nocera 2013-04-04 11:40:34 UTC
Created attachment 240584 [details]
twitter webapp

webkitgtk3-1.11.92-1.fc19.x86_64
epiphany-3.8.0-1.fc19.x86_64

Happened on both Twitter and in this bugzilla, trying to attach a screenshot with ":" in the name. Unescaped ":" in filename passed to webkit?
Comment 1 Carlos Garcia Campos 2013-04-08 13:07:00 UTC
It might be a dupe of bug #696639. Xan, do you remember if you tried to upload a file with : in the filename? or does it fail in twitter with any file?
Comment 2 Bastien Nocera 2013-04-08 13:10:05 UTC
(In reply to comment #1)
> It might be a dupe of bug #696639.

Likely

> Xan, do you remember if you tried to upload
> a file with : in the filename?

It also fails with spaces in the filename.

> or does it fail in twitter with any file?

Twitter and bugzilla worked for me once I tried to attach files that didn't have any characters that needed escaping.
Comment 3 Michael Catanzaro 2013-07-08 02:54:09 UTC
*** Bug 697831 has been marked as a duplicate of this bug. ***
Comment 4 Michael Catanzaro 2013-07-08 02:58:33 UTC
*** Bug 702582 has been marked as a duplicate of this bug. ***
Comment 5 Jean-François Fortin Tam 2013-07-08 04:45:02 UTC
If bug #702582 is truly a duplicate: for the record, whitespaces are also causing this problem, as attachment #247188 [details] demonstrates.
Comment 6 Michael Catanzaro 2013-07-08 12:50:28 UTC
Bug #702582 is almost surely a duplicate; if you rename your Bugzilla attachment to something without colons and spaces, it will attach fine and you won't see the "can't show website" screen.

By the way, this regression appeared in Epiphany 3.8 or WebKit 2.
Comment 7 Carlos Garcia Campos 2013-07-12 06:18:26 UTC
Created attachment 248984 [details]
test
Comment 8 Carlos Garcia Campos 2013-07-12 06:19:32 UTC
It seems I can't reproduce the issue
Comment 9 Carlos Garcia Campos 2013-07-12 06:24:38 UTC
hmm, in other bug reports people try to create a new bug with an attachment? Can you guys reproduce the issue when attaching a file to an existing report?
Comment 10 Bastien Nocera 2013-07-12 07:56:43 UTC
I can still reproduce the problem (trying to attach a screenshot I just took to twitter).

epiphany-3.8.2-1.fc19.x86_64
libwebkit2gtk-2.0.3-1.fc19.x86_64

The problem is most likely in WebKit itself, as the file chooser is spawned off by WebKit, not epiphany.
Comment 11 Michael Catanzaro 2013-07-12 13:23:45 UTC
Created attachment 249003 [details]
test

test test
Comment 12 Michael Catanzaro 2013-07-12 13:28:01 UTC
(In reply to comment #8)
> It seems I can't reproduce the issue

Using the same software versions as Bastien, I was also able to upload this test file.  However I cannot upload a file named "test test" with a space instead of a colon.
Comment 13 Carlos Garcia Campos 2013-07-12 13:55:44 UTC
Created attachment 249006 [details]
test with space
Comment 14 Carlos Garcia Campos 2013-07-12 13:56:28 UTC
Space instead of semicolon worked for me too.
Comment 15 Michael Catanzaro 2013-07-13 03:15:19 UTC
(In reply to comment #14)
> Space instead of semicolon worked for me too.
This seems to be broken in stable but fixed in master.  I verified this on a jhbuilt Epiphany and WebKit2 from roughly a week ago and the software versions Bastien posted above.  (I uploaded "test test" to another site since my jhbuilt Epiphany doesn't handle https.)

Normally I'd pull out the git bisect hammer at this point to figure out if there's a commit we could pick to stable. But <grumble WebKit compilation times>.
Comment 16 Carlos Garcia Campos 2013-07-14 10:27:32 UTC
I'll try again with the stable branch next week and will try to find the commit that fixed it.
Comment 17 Carlos Garcia Campos 2013-07-15 15:47:03 UTC
Created attachment 249209 [details]
Test with spaces using patched wk stable branch
Comment 18 Carlos Garcia Campos 2013-07-15 15:49:24 UTC
Ok, found the issue, it was a buggy implementation of KURL::fileSystemPath() used in GTK+ port that has been replaced in master by a better cross-platform solution. I'm going to close this as not gnome and cherrypick the fixes in the stable branch. Thank you all for your help.