GNOME Bugzilla – Bug 697206
gnome-boxes fails to build when srcdir != builddir
Last modified: 2018-01-11 10:04:48 UTC
Created attachment 240529 [details] [review] 0001-Allow-building-when-srcdir-builddir.patch libgd fails to build when srcdir != builddir i.e. when the project is build from outside of source repository. The attach patch fixes it. For full building bug #697204 needs to be resolved. The patch contains workaround for autotools bug (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13002).
Is this still valid?
git clean -dfx NOCONFIGURE=1 ./autogen.sh mkdir _build cd _build ../configure make build fails on the 3.10 branch, I cannot easily test master.
Still valid for HEAD on master. (Tested with Christophe Fergeau's commands)
Review of attachment 240529 [details] [review]: Fine apart from that. ::: src/installer-media.vala @@ +192,3 @@ private string? get_decoded_udev_property (GUdev.Device device, string property_name) { var encoded = device.get_property (property_name); + if (encoded == null) unrelated change and it has been fixed more than an year ago.
Lasse, ping?
(In reply to comment #5) > Lasse, ping? Nevermind, wrong person. Maciej, the patch is awaiting on your to act on my review AFAICT. Can you please update it soon or let me know if you don't have time.
Maciej?
Fixing Bug #690972 in libgd with the patch attached there, then applying a much simpler gnome-boxes patch which I'll attach, is enough for gnome-boxes to jhbuild. It still won't distcheck (.ui files are missing from the tarball) but that can perhaps be a separate bug.
Created attachment 329326 [details] [review] build: partially fix srcdir != builddir build A libgd change for #690972 is also required. Based on a more extensive patch by Maciej Piechotka, the rest of which might be necessary for some other use-case; this one is enough for jhbuild.
Still valid... there is a recent commit that purports to fix this, but there is rather a lot still broken, and fixing libgd is still a prerequisite.
(In reply to Michael Catanzaro from comment #10) > Still valid... there is a recent commit that purports to fix this, but there > is rather a lot still broken I assume you're referring to commit 0c4402f8 "build: Support non-srcdir builds", which was the current master commit at the time I tested Attachment #329326 [details]. I can confirm that 0c4402f8 was not enough. Attachment #329326 [details], combined with applying Attachment #235162 [details] to the embedded libgd, was enough to get my jhbuild copy building. YMMV if you are using a non-default jhbuild environment or non-default configure options; I was doing a whole-stack build (jhbuild build) on a Debian 9 base. Please could someone review those two commits as a starting point? They might not be sufficient in all situations, but they do appear to be necessary.
(In reply to Simon McVittie from comment #11) > Attachment #329326 [details], combined with applying Attachment #235162 [details] > [details] to the embedded libgd, was enough to get my jhbuild copy building. > YMMV if you are using a non-default jhbuild environment or non-default > configure options; I was doing a whole-stack build (jhbuild build) on a > Debian 9 base. Probably the difference is that I was passing --distcheck because I was making a Boxes release. srcdir != builddir from tarballs and from git are unfortunately separate beasts with Vala + Automake. Even if passing --distcheck is a rare case, we still need to make sure this works before removing supports-non-srcdir-builds="no" as we do tarball builds when making the overall GNOME releases.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/12.