After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697204 - libgd fails to build when srcdir != builddir
libgd fails to build when srcdir != builddir
Status: RESOLVED DUPLICATE of bug 690972
Product: libgd
Classification: Platform
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: libgd maintainer(s)
Depends on:
Blocks: 697206
 
 
Reported: 2013-04-03 18:01 UTC by Maciej (Matthew) Piechotka
Modified: 2013-04-04 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Allow-building-when-srcdir-builddir.patch (1.12 KB, patch)
2013-04-03 18:01 UTC, Maciej (Matthew) Piechotka
none Details | Review

Description Maciej (Matthew) Piechotka 2013-04-03 18:01:13 UTC
Created attachment 240525 [details] [review]
0001-Allow-building-when-srcdir-builddir.patch

libgd fails to build when srcdir != builddir i.e. when the project is build from outside of source repository. The attach patch fixes it.
Comment 1 Christophe Fergeau 2013-04-03 18:46:47 UTC
Review of attachment 240525 [details] [review]:

::: Makefile.am
@@ +232,1 @@
+$(builddir)/gd-1.0.vapi: $(builddir)/Gd-1.0.gir

This is unfortunately not that simple, as tarballs are supposed to ship the .vapi file, and to be buildable without needing vala. In this case, $(srcdir)/gd-1.0.vapi would be correct.
Comment 2 Maciej (Matthew) Piechotka 2013-04-03 18:56:12 UTC
(In reply to comment #1)
> Review of attachment 240525 [details] [review]:
> 
> ::: Makefile.am
> @@ +232,1 @@
> +$(builddir)/gd-1.0.vapi: $(builddir)/Gd-1.0.gir
> 
> This is unfortunately not that simple, as tarballs are supposed to ship the
> .vapi file, and to be buildable without needing vala. In this case,
> $(srcdir)/gd-1.0.vapi would be correct.

The srcdir should not be modified though. My guess it should output to $(builddir) - however the lookup should be done from 2 places - the change for valac would be simple - bigger problem would be with installing vapi (which is not a problem for libgd at this moment).
Comment 3 Cosimo Cecchi 2013-04-04 18:35:38 UTC
I believe this is the same problem reported in bug 690972.

*** This bug has been marked as a duplicate of bug 690972 ***