After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695418 - Unsharp mask crashes for large radii
Unsharp mask crashes for large radii
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.8.4
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
: 705554 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-08 01:37 UTC by Moltres_rider
Modified: 2013-08-11 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Stack trace of bug (20.43 KB, text/plain)
2013-03-08 22:37 UTC, Mike Henning (drawoc) 		  Details
Simple bound check (1.42 KB, patch)
2013-04-07 20:39 UTC, Téo Mazars 		accepted-commit_now Details | Review

Description Moltres_rider 2013-03-08 01:37:27 UTC 
if you adjust the 'amount' slider on the unsharpen mask option in Gimp more than halfway to the right with the radius all the way to the right Gimp ALWAYS crashes!!!
Comment 1 Michael Schumacher 2013-03-08 08:05:01 UTC 
Works fine here, I can go all the way to 500 without any ill effects, except a slightly longer wait.
Comment 2 André Klapper 2013-03-08 10:33:51 UTC 
Please avoid exclamation marks and capital letters.
Comment 3 Moltres_rider 2013-03-08 21:49:58 UTC 
tried it on 6 pictures around 700x700px, still ALWAYS crashing
Comment 4 Michael Schumacher 2013-03-08 21:57:06 UTC 
Maybe you could describe the steps you do (so anyone can follow them without knowing what you do, or looking at your screen), or attach a screenshot of the unsharp mask dialog before you increase the radius?
Comment 5 Moltres_rider 2013-03-08 22:22:31 UTC 
all I do is adjust the sliders about half way and  it crashes before even hitting the button to perform the task! it doesn't mater what I do before, adjusting sliders at least half way = crash! it could be the first thing I do and it crashes!!
Comment 6 Mike Henning (drawoc) 2013-03-08 22:37:11 UTC 
Created attachment 238428 [details]
Stack trace of bug

I can reproduce this by changing only the radius. Here is a stack trace.

It only happens with large radius values - a radius of 426 does not crash for me; 427 does crash (I left all other values at the defaults). This is on a 640x400 image.

I'm running arch linux 64 bit.
Comment 7 Michael Schumacher 2013-03-08 22:53:47 UTC 
Moltres, you're using a 64 bit system as well?
Comment 8 Moltres_rider 2013-03-08 23:06:04 UTC 
32 bit... Windows 7

call me 'Moltres Rider'
Comment 9 Michael Schumacher 2013-03-30 09:49:01 UTC 
As per comment #6
Comment 10 Téo Mazars 2013-04-07 20:39:34 UTC 
Created attachment 240905 [details] [review]
Simple bound check

On small images + large radii, the plugin did not care if it worked on the image or not... With this patch it does.

Submitted against gimp-2-8
Comment 11 Michael Natterer 2013-04-07 21:06:56 UTC 
Comment on attachment 240905 [details] [review]
Simple bound check

If that fixes it, please push to 2-8 and master.
Comment 12 Téo Mazars 2013-04-08 17:21:35 UTC 
Pushed to master and gimp-2-8. This plugin is no longer used in master though... And I don't see how to close the bug, help!

commit 35cc644765c553b6feb24bd56133b6f9f74ed5e4
Author: Téo Mazars <teo.mazars@ensimag.fr>
Date:   Sun Apr 7 22:29:56 2013 +0200

    Bug 695418 - Unsharp mask crashes for large radii
    
    Make sure we are working on the image range

 plug-ins/common/unsharp-mask.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 13 Massimo 2013-08-11 15:00:56 UTC 
*** Bug 705554 has been marked as a duplicate of this bug. ***