GNOME Bugzilla – Bug 693626
a11y-settings: take osk into account too
Last modified: 2013-02-12 15:18:03 UTC
There's no a11y-settings component, thus filing under general.
Created attachment 235758 [details] [review] a11y-settings: take osk into account too The OSK needs toolkit-accessibility too, so take it into account as well when updating the setting.
I don't agree. In fact, you're reverting this patch which does the exact opposite: commit c52025fae0bb12c130450211bb9168fc321a707c Author: Bastien Nocera <hadess@hadess.net> Date: Thu Aug 4 16:49:32 2011 +0100 a11y-settings: gnome-shell OSK doesn't need a11y So don't try and load the modules. Only Caribou in fallback mode would have needed it. #fallback https://bugzilla.gnome.org/show_bug.cgi?id=655985 Why do we need to take the OSK into account?
The OSK needs the a11y infrastructure in the toolkit working to know when editable widgets get/lose focus. The caribou daemon proxies those events to the shell which then shows/hides the OSK.
See bug 693616 which is about removing the same code for turning on toolkit-accessibility from caribou. Doesn't make sense to do it in 2 places
(In reply to comment #4) > See bug 693616 which is about removing the same code for turning on > toolkit-accessibility from caribou. Doesn't make sense to do it in 2 places That could should be removed. I'll revert the original patch on the basis that the toolkit accessibility setting is what will load atk and at-spi2-core support in gtk2 apps.
commit b10d1902a767c674acea7fa7847156d469704288 Author: Bastien Nocera <hadess@hadess.net> Date: Tue Feb 12 16:16:23 2013 +0100 Revert "a11y-settings: gnome-shell OSK doesn't need a11y" It doesn't, but GTK2 apps need this to export the fact that an entry is focused for example. This reverts commit c52025fae0bb12c130450211bb9168fc321a707c. See https://bugzilla.gnome.org/show_bug.cgi?id=693626