GNOME Bugzilla – Bug 693616
Tells me that a11y is off and need to log out
Last modified: 2013-02-13 16:01:04 UTC
Created attachment 235740 [details] screenshot When turning on the OSK from the shell a11y menu I get two dialogs. The first telling me that a11y is off and I should turn it on. Then a dialog pops up on top of that and tells me I need to log out. * a11y should not need to be turned on by the user * if unable to initialize a11y something more serious is wrong * we shouldn't ask the user to log out * we shouldn't pop up a gtk dialog out of the blue. If it is absolutely needed it should be a shell style dialog. * We shouldn't pop up one dialog on top of another.
It turns out that org.gnome.desktop.interface.toolkit-accessibility defaults to false, still. Setting it to true is needed for gtk2 apps only. Neither gtk3 (where it is always on) nor clutter (where it defaults to true) rely on it. We are also inconsistent here: orca does not display a similar dialog, it just starts up.
Created attachment 235757 [details] [review] Don't check the toolkit-accessibility setting It is irrelevant for gtk3 and clutter apps.
In fact, we already have code in the a11y-settings plugin in gsd to silently enable toolkit-accessibility as long as orca is running - we should just extend that to cover the osk as well.
See bug 693626 for the gsd side
the gsd patch has landed now
Review of attachment 235757 [details] [review]: Looks good to me. For the record, here is the original bug which introduced the dialog: https://bugzilla.gnome.org/show_bug.cgi?id=645890 and the patch author also confirmed that it could be removed now.
Attachment 235757 [details] pushed as 0eb7a51 - Don't check the toolkit-accessibility setting