GNOME Bugzilla – Bug 692746
history uses wrong encoding to show utf8 logs
Last modified: 2013-05-24 12:48:58 UTC
Hi! My distro is gentoo ~amd64. Today I I have upgraded from gnome 3.4 up to 3.6. Empathy was upgraded up to 3.6.3. After upgrade I have noticed that history (previous conversations) shows my log in wrong way (it looks like utf8 text interpreted as a single byte encoding text): see screenshot. I have checked that my logs in ~/.local/share/TpLogger/ are in utf8. Then I downgrade empathy up to 3.6.2 and restart gnome-session. This is fixed my problem. I have checked several times and can confirm that with empathy 3.6.2 the bug is not reproducible, but reproducible with 3.6.3.
Created attachment 234671 [details] cyrillic logs in empathy 3.6.3
It is not surprising that problematic commit is http://git.gnome.org/browse/empathy/commit/?h=gnome-3-6&id=1e7449f5a14e2f031389808206c9991f65d3ade7
*** Bug 692984 has been marked as a duplicate of this bug. ***
Do you plan to fix this for 3.8?
Confirmed. This is also a problem for German, French, etc.
The problem here is that g_strescape changed its specifications over time - from the UTF-8-compatible "double every backslash" to ASCII-only "escape everything except 0x20 through 0x7E". Would it be right to invent a new backslash-doubling function for empathy-log-window.c specifically? Not pretty, but passing a 128-character exception string to g_strescape is even less so. (The backslashes get interpreted when pasted into Javascript by insert_or_change_row and friends, right?)
Ni! Bug still present in Empathy 3.8.1
Same with Chinese and 3.8.1. Why is this still new?
*** Bug 699193 has been marked as a duplicate of this bug. ***
confirm. 3.8.2.
I think this bug duplicate of bug #89548
Created attachment 244626 [details] [review] use g_utf8_strescape instead of g_strescape Need update bug. Add blocker bugs: bug #89548 Apply patch after close bug #89548 .
Please change Version to git
There is no "git" product version for this component. xgdgsc: NEW is "confirmed" in gnome bugzilla.
(In reply to comment #14) > There is no "git" product version for this component. Thx for the correction. I not owner of this bug.
I reverted the commit introducing this regression. I'll do a 3.8 release shortly. commit 7e2db943e0c9a6f5764504460e64ffec9bb87d67 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Fri May 24 14:43:27 2013 +0200 Revert "log-window: escape the body of the message" This commit introduced a nasty regression breaking UTF-8 logs (#692746). I prefer to revert it as #691085 was a far less anoying bug. We'll re-fix #691085 once we'll have a UTF-8 friendly escape function in GLib (#89548). This reverts commit 1e7449f5a14e2f031389808206c9991f65d3ade7.