GNOME Bugzilla – Bug 692525
keyboard: Adapt to gnome-xkb-info API change
Last modified: 2019-03-20 11:07:35 UTC
See patches.
Created attachment 234386 [details] [review] configure: Move some pkg-config checks to shared definitions These are already used by many plugins and the daemon so they might as well go into common modules.
Created attachment 234387 [details] [review] keyboard: Adapt to gnome-xkb-info API change
Review of attachment 234386 [details] [review]: Prefix with "build" not "configure". ::: configure.ac @@ +68,2 @@ gsettings-desktop-schemas >= $GSETTINGS_DESKTOP_SCHEMAS_REQUIRED_VERSION + gnome-desktop-3.0 >= $GNOME_DESKTOP_REQUIRED_VERSION why is gnome-desktop-3.0 a requirement for the *daemon*?
Review of attachment 234387 [details] [review]: Looks good.
Created attachment 234395 [details] [review] build: Move some pkg-config checks to shared definitions -- (In reply to comment #3) > Prefix with "build" not "configure". Ok. > ::: configure.ac > @@ +68,2 @@ > gsettings-desktop-schemas >= $GSETTINGS_DESKTOP_SCHEMAS_REQUIRED_VERSION > + gnome-desktop-3.0 >= $GNOME_DESKTOP_REQUIRED_VERSION > > why is gnome-desktop-3.0 a requirement for the *daemon*? That commit: d8c158e7 Create a reference to a GnomePnpIds object to speed up loading
Comment on attachment 234387 [details] [review] keyboard: Adapt to gnome-xkb-info API change Attachment 234387 [details] pushed as 8174dcd - keyboard: Adapt to gnome-xkb-info API change
Review of attachment 234395 [details] [review]: ::: configure.ac @@ +68,2 @@ gsettings-desktop-schemas >= $GSETTINGS_DESKTOP_SCHEMAS_REQUIRED_VERSION + gnome-desktop-3.0 >= $GNOME_DESKTOP_REQUIRED_VERSION > That commit: > d8c158e7 Create a reference to a GnomePnpIds object to speed up loading It's a bug fix for that bug, please commit separately. @@ -110,2 @@ dnl --------------------------------------------------------------------------- -dnl - Check for libnotify I'm fine with that, but it should be a separate patch. @@ +130,3 @@ dnl --------------------------------------------------------------------------- +PKG_CHECK_MODULES(COMMON, kbproto xi) Are you dropping x11 because it's a dep of one/both of those? Then please make this a separate patch. @@ +144,3 @@ dnl --------------------------------------------------------------------------- +PKG_CHECK_MODULES(MOUSE, xi) Ditto. ::: plugins/background/Makefile.am @@ -20,3 @@ $(PLUGIN_CFLAGS) \ $(SETTINGS_PLUGIN_CFLAGS) \ - $(BACKGROUND_CFLAGS) \ Please keep this code as-is, even if the variables don't actually exist. There's a seperate bug and patch about removing it all.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/202.