After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692413 - Move gdm-languages from gnome-control-center as gnome-languages
Move gdm-languages from gnome-control-center as gnome-languages
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks: 692414 692525
 
 
Reported: 2013-01-23 19:07 UTC by Rui Matos
Modified: 2013-01-25 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
post-release version bump (741 bytes, patch)
2013-01-23 19:07 UTC, Rui Matos
committed Details | Review
gnome-languages: Extracted from gnome-control-center (49.86 KB, patch)
2013-01-23 19:07 UTC, Rui Matos
committed Details | Review
gnome-languages: Fix a memory leak (1.07 KB, patch)
2013-01-23 19:07 UTC, Rui Matos
committed Details | Review
gnome-xkb-info: Group layouts by country and language (9.61 KB, patch)
2013-01-23 19:07 UTC, Rui Matos
none Details | Review
gnome-xkb-info: Add a get_layout_info_for_locale method (6.68 KB, patch)
2013-01-23 19:07 UTC, Rui Matos
none Details | Review
gnome-xkb-info: Group layouts by country and language (10.52 KB, patch)
2013-01-25 13:32 UTC, Rui Matos
committed Details | Review
gnome-xkb-info: Add a get_layout_info_for_locale method (6.45 KB, patch)
2013-01-25 13:32 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2013-01-23 19:07:04 UTC
See patches.
Comment 1 Rui Matos 2013-01-23 19:07:06 UTC
Created attachment 234237 [details] [review]
post-release version bump
Comment 2 Rui Matos 2013-01-23 19:07:10 UTC
Created attachment 234238 [details] [review]
gnome-languages: Extracted from gnome-control-center

This used to be panels/common/gdm-languages.c in gnome-control-center
but it's useful in several core desktop modules so let's move it here
and s/gdm/gnome/.
Comment 3 Rui Matos 2013-01-23 19:07:13 UTC
Created attachment 234239 [details] [review]
gnome-languages: Fix a memory leak
Comment 4 Rui Matos 2013-01-23 19:07:17 UTC
Created attachment 234240 [details] [review]
gnome-xkb-info: Group layouts by country and language

This will allow us to do better guesses at which layout should be the
default for a given locale.
Comment 5 Rui Matos 2013-01-23 19:07:21 UTC
Created attachment 234241 [details] [review]
gnome-xkb-info: Add a get_layout_info_for_locale method

Now that we have layouts grouped properly by country and language we
can implement an accurate get_layout_info_for_locale method instead of
the hacky solution that we had before.
Comment 6 Rui Matos 2013-01-25 13:32:04 UTC
Created attachment 234389 [details] [review]
gnome-xkb-info: Group layouts by country and language

--
Fixed some bugs found with more extensive testing.
Comment 7 Rui Matos 2013-01-25 13:32:14 UTC
Created attachment 234390 [details] [review]
gnome-xkb-info: Add a get_layout_info_for_locale method

--
Fixed some bugs found with more extensive testing.
Comment 8 Bastien Nocera 2013-01-25 13:50:56 UTC
Review of attachment 234237 [details] [review]:

++
Comment 9 Bastien Nocera 2013-01-25 13:51:56 UTC
Review of attachment 234238 [details] [review]:

Looks good.
Comment 10 Bastien Nocera 2013-01-25 13:53:28 UTC
Review of attachment 234239 [details] [review]:

Backport to gnome-control-center's gnome-3-6 branch as well.
Comment 11 Bastien Nocera 2013-01-25 13:55:04 UTC
Review of attachment 234389 [details] [review]:

Looks good.
Comment 12 Bastien Nocera 2013-01-25 13:56:28 UTC
Review of attachment 234390 [details] [review]:

Looks good.
Comment 13 Rui Matos 2013-01-25 14:52:48 UTC
Thanks for reviewing. I also pushed the mem leak fix to the control
center 3.6 branch.

Attachment 234237 [details] pushed as 44f6650 - post-release version bump
Attachment 234238 [details] pushed as cc16a0e - gnome-languages: Extracted from gnome-control-center
Attachment 234239 [details] pushed as 09d15b8 - gnome-languages: Fix a memory leak
Attachment 234389 [details] pushed as 5e86bb4 - gnome-xkb-info: Group layouts by country and language
Attachment 234390 [details] pushed as 57b0643 - gnome-xkb-info: Add a get_layout_info_for_locale method