After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691699 - power: Don't switch on DPMS when suspending
power: Don't switch on DPMS when suspending
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-14 08:58 UTC by Bastien Nocera
Modified: 2013-01-14 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
power: Don't switch off DPMS when suspending (1.25 KB, patch)
2013-01-14 08:58 UTC, Bastien Nocera
none Details | Review
power: Don't switch on DPMS when suspending (1.25 KB, patch)
2013-01-14 11:27 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-01-14 08:58:40 UTC
.
Comment 1 Bastien Nocera 2013-01-14 08:58:43 UTC
Created attachment 233422 [details] [review]
power: Don't switch off DPMS when suspending

We already do it when resuming.
Comment 2 Bastien Nocera 2013-01-14 10:17:31 UTC
Incorrect, sorry about the noise.
Comment 3 Bastien Nocera 2013-01-14 10:20:42 UTC
What am I doing, this is correct, and would stop the patch in bug 691702 from working if not applied.
Comment 4 Bastien Nocera 2013-01-14 11:27:43 UTC
Created attachment 233437 [details] [review]
power: Don't switch on DPMS when suspending

We already do it when resuming.
Comment 5 Bastien Nocera 2013-01-14 11:28:46 UTC
Comment on attachment 233422 [details] [review]
power: Don't switch off DPMS when suspending

Typo in the commit message
Comment 6 Bastien Nocera 2013-01-14 11:29:03 UTC
(In reply to comment #5)
> (From update of attachment 233422 [details] [review])
> Typo in the commit message

And in the subject line.
Comment 7 Richard Hughes 2013-01-14 11:49:27 UTC
Review of attachment 233437 [details] [review]:

Looks good, thanks.
Comment 8 Bastien Nocera 2013-01-14 12:04:32 UTC
Attachment 233437 [details] pushed as aa6d44d - power: Don't switch on DPMS when suspending