GNOME Bugzilla – Bug 691702
power: Switch off backlight before suspend
Last modified: 2013-01-14 12:04:58 UTC
.
Created attachment 233428 [details] [review] power: Switch off backlight before suspend When suspending, switch off the backlight and turn it back on when resuming. Note that we need to capture the current backlight before DPMS Off, otherwise xbacklight will return zero. FIXME: suspending without closing the lid should do the same...
Created attachment 233429 [details] [review] power: Switch off backlight before suspend When suspending, switch off the backlight and turn it back on when resuming. Note that we need to capture the current backlight before DPMS Off, otherwise xbacklight will return zero.
Review of attachment 233429 [details] [review]: We shouldn't actually set DPMS on in the lid closed handler, as that wouldn't take external monitors into account. Furthermore, the xrandr plugin already takes care of switching off the output when the lid closes.
Created attachment 233435 [details] [review] power: Don't turn DPMS off when closing the lid That doesn't take external monitors into account, and would just switch them off[1]:. Furthermore, the xrandr plugin already takes care of switching off the laptop output when the lid closes. https://bugzilla.gnome.org/show_bug.cgi?id=691702 [1]: Though the effect isn't too critical as we can move the mouse to revive the main monitor.
Review of attachment 233435 [details] [review]: Looks good, thanks.
Created attachment 233436 [details] [review] power: Switch off backlight before suspend When suspending, switch off the backlight and turn it back on when resuming. Note that we need to capture the current backlight before DPMS Off, otherwise xbacklight will return zero.
Comment on attachment 233436 [details] [review] power: Switch off backlight before suspend It's probably worth noting in the commit message that this only works on MBP hardware, and that it's relying on a quirk in the intel KMS driver.
Created attachment 233438 [details] [review] power: Don't turn DPMS off when closing the lid That doesn't take external monitors into account, and would just switch them off[1]:. Furthermore, the xrandr plugin already takes care of switching off the laptop output when the lid closes. https://bugzilla.gnome.org/show_bug.cgi?id=691702 [1]: Though the effect isn't too critical as we can move the mouse to revive the main monitor.
Attachment 233436 [details] pushed as 168d3ee - power: Switch off backlight before suspend Attachment 233438 [details] pushed as df29c45 - power: Don't turn DPMS off when closing the lid