GNOME Bugzilla – Bug 691333
Regression: Border page color can be distracting
Last modified: 2013-03-20 18:09:05 UTC
The border page since gnome3-style merge seems themable. By default it looks blue-ish. When used Fit-Width is usually fine. It is distracting when using 'Fit Page' and there is space in the left and right side of the page. By distracting I mean when I try to read the actual content (rather than skimming the document), the blue-ish color drives my attention to the border rather than the content. IMVHO, the border should play a secondary role because the primary role of evince is allow the user read documents. Attached a screenshot of the primary screen. The screen is big enough to read comfortable in that size (in spite of the zoom of 91.61%). The image is compressed at 85%.
Did you forget to attach the screenshot ?
Created attachment 233001 [details] Screenshot with the border in FitPage mode
IMVHO, the border could be dark grey and light grey. I think in Ubuntu the border would look orange-ish and in OpenSUSE it would look green-ish, both of them equally distracting.
I think Documents uses a cool shadow, I don't know if that's done in Documents itself or in gnome-themes-standard but we could use the same, not only because it's cool, but also for consistency.
Created attachment 238053 [details] [review] shell: use standard theme for page borders. GNOME Documents uses the default border: http://git.gnome.org/browse/gnome-themes-standard/tree/themes/Adwaita/gtk-3.0/gtk-widgets.css#n3756 which Evince overrides. The original patch was introduced with: https://bugzilla.gnome.org/review?bug=653294&attachment=230907 With this patch, there is not difference between "focused" and "unfocused" page. The previous behaviour was a bit odd in dual pages because only one (usually the left page) looked like focused. The discussion in IRC with Cosimo was the following: <gpoo> I have git grep-ed gnome-document looking for the place you draw the border in gnome-documents, but I failed to find it <gpoo> I also searched in adwaita theme <cosimoc> gpoo, it's done in the theme IIRC <cosimoc> gpoo, and I think it was done that way in Evince because Carlos initially didn't want the same border there <cosimoc> but we can probably still change it from the theme, let me see <gpoo> how is the border color in gnome-documents when it has the focus? <cosimoc> gpoo, it doesn't change with focus <gpoo> ok, so I guess you do not change anything and let the theme to do it <gpoo> if I understood correctly <gpoo> at least in http://git.gnome.org/browse/gnome-themes-standard/tree/themes/Adwaita/gtk-3.0/gnome-applications.css#n236 there is nothing like that <cosimoc> gpoo, ok got it <cosimoc> http://git.gnome.org/browse/evince/tree/shell/evince.css#n20 is the evince style <cosimoc> http://git.gnome.org/browse/gnome-themes-standard/tree/themes/Adwaita/gtk-3.0/gtk-widgets.css#n3756 is the documents one <cosimoc> gpoo, I think it you just remove the custom evince styling it would just pick up the documents one <gpoo> I will try that <gpoo> thanks! <jjmarin> gpoo: hi ! Are trying to fix the blue selection thumbnail bug ? <gpoo> I will take a look at it <jjmarin> great ! <gpoo> indeed, removing the custom css of evview does the trick <jjmarin> gpoo: why evview needs a custom css ? <gpoo> I have no idea <gpoo> maybe chpe has the background <gpoo> It would need to re-check the discussion when it was introduced <gpoo> jjmarin: https://bugzilla.gnome.org/show_bug.cgi?id=653294 <gpoo> and maybe http://git.gnome.org/browse/evince/commit/?id=dbc67b85fa737fa9a66 <jjmarin> Well, I though the main problem was that the thumbnail selection was oversized <jjmarin> s/though/thought <gpoo> that is a different bug <gpoo> that was solved with a custom cell rendered, iirc <chpe> don't know, sorry <cosimoc> gpoo, I think it'd make sense for evince to drop that custom CSS and use the other border FWIW <gpoo> cosimoc: I agree, but I think people are used to having a way to know what is the "current page" (the focused one) <cosimoc> gpoo, it wasn't blue before 3.7 IIRC <gpoo> no, it was a black shadow for focused pages and grey shadow for unfocused ones <gpoo> I wonder if the current page is really that important <gpoo> in dual-page it does not change between left and right page <cosimoc> gpoo, the current page is the one in front of you :) <cosimoc> I don't think there's a need for an additional indication really <gpoo> I think it was made for continuous page <cosimoc> still <gpoo> fwiw, I am just being devil's advocate <gpoo> I agree with you <cosimoc> in the edge case where you're in the middle of two pages it still doesn't really matter
Created attachment 238055 [details] Screenshot with patch applied (using borders from the theme)
I don't like the blue thing either, and I agree the theme border is a lot nicer. What I didn't want was to lose the feature of highlighting the current page, and when page border was made css stylable, the default active color was the on one in effect to highlight the current page. It's unfortunate because it's really distracting and doesn't really gives the idea of "this is the current page". I guess it could be improved to use the theme border and use a different level of darkness for the current page or something like that, but I don't know CSS. Anyway, I agree the feature is kind of broken in dual mode, and with the current blue is even more broken, so I'll use the theme one, also for consistency with Documents.
Review of attachment 238053 [details] [review]: I've pushed the patch to git master removing the :active from the CSS. ::: shell/evince.css @@ +23,3 @@ } EvView.document-page:active { We don't need the active anymore.