GNOME Bugzilla – Bug 653294
Make page and thumbnail borders styleable with CSS
Last modified: 2012-12-23 12:29:29 UTC
Created attachment 190547 [details] dropshadow i have two simple suggestions concerning the overall look of evince. since im no programmer i cant estimate how much time it takes to apply these ideas, but they seem easy and efficient for the appeal of evince. 1. since libreoffice 3.4 the pages have a appealing drop-shadow instead of the hard black shadow, which looks very nice. since its already working in libreoffice, isnt easy to port it to evince? 2. the search bar function of the newest gedit version is very comfortable and size saving. having it in evince would also account for a overall look in gnome.
Created attachment 190548 [details] searchbar
I'm going to focus this report on improving the page border. Please file a new bug for improvements to the search functionality. I'm going to attach a couple patches that make the borders styleable from CSS. I'm going to need Cosimo's help making the style use a drop shadow.
Created attachment 230261 [details] [review] Use a rendered frame instead of custom border So it can be styled with CSS.
Created attachment 230262 [details] [review] Allow sidebar thumbnails to be styled with CSS
Created attachment 230336 [details] [review] Allow sidebar thumbnails to be styled with CSS
Created attachment 230713 [details] [review] Use a rendered frame instead of custom border So it can be styled with CSS.
Created attachment 230714 [details] [review] Allow sidebar thumbnails to be styled with CSS
Created attachment 230715 [details] [review] Set a style class on the view so it can be more easily styled And share the style we use for other content views.
Review of attachment 230713 [details] [review]: I'm fine with using CSS for the border, but I don't want to remove the shadow nor the current page highlight. Also, I would like to make sure that the theme can't break the page rendering, I had to add custom CSS because we depended on the theme and changes in adwaita broke the page rendering. See http://git.gnome.org/browse/evince/commit/?id=dbc67b85fa737fa9a66c4bc7b4c30e82be9c8543
Review of attachment 230714 [details] [review]: Same here, why removing the shadow? I would agree on removing the shadow for the thumbnails, but I think it's a different issue, this bug is about allowing the thumbnails and page to be styled with CSS not about actually changing the current style, no?
Created attachment 230907 [details] [review] Use a rendered frame instead of custom border So it can be styled with CSS.
Created attachment 230908 [details] [review] Allow sidebar thumbnails to be styled with CSS
Review of attachment 230715 [details] [review]: Pushed, thanks!
Review of attachment 230907 [details] [review]: Committed a slightly different version, to keep API compatibility. Now paint one page is just gtk_render_background + rende_frame, so I've moved that code to the view, leaving he old code in documnet_misc that will be marked as deprecated.
Review of attachment 230908 [details] [review]: Also committed a different version to keep API compatibility. I've added two new functions: ev_document_misc_render_loading_thumbnail() and ev_document_misc_render_thumbnail_with_frame(). To render the thumbnails without a frame you need to call ev_job_thumbnail_set_has_frame (job, FALSE).