After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690962 - port to python3
port to python3
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
: 758490 (view as bug list)
Depends on:
Blocks: python3
 
 
Reported: 2013-01-01 23:26 UTC by Matthias Clasen
Modified: 2015-12-02 01:00 UTC
See Also:
GNOME target: 3.18
GNOME version: 3.15/3.16


Attachments
python3: use relative imports (3.38 KB, patch)
2013-01-04 05:59 UTC, Daiki Ueno
none Details | Review
python3: misc function changes (1.94 KB, patch)
2013-01-04 05:59 UTC, Daiki Ueno
none Details | Review
python3: exception changes (3.44 KB, patch)
2013-01-04 05:59 UTC, Daiki Ueno
none Details | Review
python3: whitespace and comma cleanup (1.16 KB, patch)
2013-01-04 06:00 UTC, Daiki Ueno
none Details | Review
python3: use print() function instead of print statement (4.34 KB, patch)
2013-01-04 06:00 UTC, Daiki Ueno
none Details | Review
python3: list-related changes (1.53 KB, patch)
2013-01-04 06:00 UTC, Daiki Ueno
none Details | Review

Description Matthias Clasen 2013-01-01 23:26:25 UTC
See https://live.gnome.org/GnomeGoals/Python3Porting
Comment 1 Daiki Ueno 2013-01-04 05:59:51 UTC
Created attachment 232705 [details] [review]
python3: use relative imports
Comment 2 Daiki Ueno 2013-01-04 05:59:54 UTC
Created attachment 232706 [details] [review]
python3: misc function changes
Comment 3 Daiki Ueno 2013-01-04 05:59:57 UTC
Created attachment 232707 [details] [review]
python3: exception changes
Comment 4 Daiki Ueno 2013-01-04 06:00:00 UTC
Created attachment 232708 [details] [review]
python3: whitespace and comma cleanup
Comment 5 Daiki Ueno 2013-01-04 06:00:03 UTC
Created attachment 232709 [details] [review]
python3: use print() function instead of print statement
Comment 6 Daiki Ueno 2013-01-04 06:00:07 UTC
Created attachment 232710 [details] [review]
python3: list-related changes
Comment 7 Daiki Ueno 2013-01-04 06:07:45 UTC
Based on the result of 2to3.  Luckily, these patches are all compatible with python 2.7.  Tested with "PYTHON=python3 ./configure ... && make && make install".
Comment 8 Matthias Clasen 2013-01-21 23:00:27 UTC
that is great to hear; it now appears we'll have to stick with python 2.7 for f19, at least.
Comment 9 Matthias Clasen 2013-02-15 23:31:02 UTC
it seems we're going for a vala port instead ?
Comment 10 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-02-18 11:49:43 UTC
(In reply to comment #9)
> it seems we're going for a vala port instead ?

Thats what I understood from bug 688218. Shouldn't this bug being closed?
Comment 11 Javier Jardón (IRC: jjardon) 2015-06-20 12:18:07 UTC
Sorry I reopened this, but in current master I can still see in the configure.ac:

dnl == check for python ==
AM_PATH_PYTHON(2.4)

and several python files are present in the tree:

$ find -name *.py
./caribou/settings/preferences_window.py
./caribou/settings/setting_types.py
./caribou/settings/settings_manager.py
./caribou/settings/caribou_settings.py
./caribou/settings/__init__.py
./caribou/__init__.py
./caribou/antler/keyboard_view.py
./caribou/antler/__init__.py
./caribou/antler/antler_settings.py
./caribou/antler/main.py
./caribou/antler/window.py
./tools/convert_cldr.py
./tools/fix_gir.py
./tools/make_schema.py
Comment 12 Daiki Ueno 2015-06-20 20:17:58 UTC
Does that cause any error?  Those python files are classified into:

- only used at build time: tools/fix_gir.py, tools/make_schema.py
- only used for testing purpose: tools/convert_cldr.py
- only used by non-GNOME environment: caribou/*

Given that all those files work with both python 3 and python 2,
and AM_PATH_PYTHON takes the minimum version of the python
interpreter, there shouldn't be a problem.
Comment 13 Matthias Clasen 2015-09-04 13:48:46 UTC
Javier, what problem were you seeing ?
Comment 14 Javier Jardón (IRC: jjardon) 2015-09-04 16:29:27 UTC
I think I had problems building this with python3; I've checked again an everything is fine, closing again (sorry for the noise)
Comment 15 Daiki Ueno 2015-12-02 01:00:40 UTC
*** Bug 758490 has been marked as a duplicate of this bug. ***