GNOME Bugzilla – Bug 688218
port daemon from Python to Vala
Last modified: 2013-02-17 01:29:17 UTC
Split off from bug 688149. Also finished the porting and removed Python and shell script wrappers.
Created attachment 228850 [details] [review] daemon: port to Vala https://bugzilla.gnome.org/show_bug.cgi?id=688149
Created attachment 229434 [details] [review] Move external vapi files under $(top_srcdir)/vapi -- I'd like to split the patch into three: 1. move *.vapi files from libcaribou/ to vapi/, so that daemon code can also use them 2. add necessary atspi-2.vapi and config.vapi 3. actually port the daemon code to Vala I think this split will make the review a little easier.
Created attachment 229435 [details] [review] Include atspi-2.vapi and config.vapi
Created attachment 229436 [details] [review] Port daemon from Python to Vala This eliminates the need of the shell script wrapper and allows further enhancement including X event tracking (bug 688149).
Created attachment 236219 [details] [review] Move external vapi files under $(top_srcdir)/vapi -- rebased
Created attachment 236220 [details] [review] Include atspi-2.vapi and config.vapi -- rebased
Created attachment 236221 [details] [review] Port daemon from Python to Vala This eliminates the need of the shell script wrapper. -- rebased
Now that the a11y dialog has been removed (bug 693616), the Vala port should behave exactly same as the Python version. So I'll land this soon if no objection.
no objection. In fact, strongly in favour of it.
Attachment 236219 [details] pushed as ef0866d - Move external vapi files under $(top_srcdir)/vapi Attachment 236220 [details] pushed as 4000c25 - Include atspi-2.vapi and config.vapi Attachment 236221 [details] pushed as 1b7a0c6 - Port daemon from Python to Vala