After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690673 - Avatar image is not scaled
Avatar image is not scaled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
: 701023 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-12-23 16:48 UTC by Piotr Drąg
Modified: 2013-11-15 19:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
How it looks like (199.79 KB, image/jpeg)
2012-12-23 16:48 UTC, Piotr Drąg
  Details
patch (2.10 KB, patch)
2013-10-23 20:47 UTC, sébastien lafargue
needs-work Details | Review
scale correcty avatar image in loginDialog (719 bytes, patch)
2013-10-27 11:44 UTC, sébastien lafargue
none Details | Review

Description Piotr Drąg 2012-12-23 16:48:51 UTC
Created attachment 232151 [details]
How it looks like

After setting avatar in control-center and messing with rights to ~/.face, login screen shows my avatar in the user list. However instead of scaling it to fit the box, it displays just a fragment of it.

This is how my avatar should look like (128x128px):

http://raven.fedorapeople.org/avatar.png

In the attachment there is a photo of login screen with the avatar clipped.
Comment 1 Teppo Turtiainen 2013-01-15 08:06:04 UTC
I can confirm that this happens.
Comment 2 Allan Day 2013-06-15 00:15:16 UTC
*** Bug 701023 has been marked as a duplicate of this bug. ***
Comment 3 Piotr Drąg 2013-06-22 22:47:13 UTC
Interestingly, after selecting a user the avatar is properly scaled.
Comment 4 karashata 2013-06-22 23:50:17 UTC
I suggested a fairly easy fix, adding the line "background-size: contain;" to the declaration for .login-dialog-user-list-item-icon but it seems they might not want to do it that way...

I can confirm, however, that it will scale the user icon to fit the box provided, rather than cropping it as it currently does when the icon is larger than 64*64 pixels.
Comment 5 sébastien lafargue 2013-10-23 20:47:22 UTC
Created attachment 257968 [details] [review]
patch

actually, 'login-dialog-not-listed-button' style overwrite the default one in Avatar, so no more background-size: contain style

With this patch, every image is scaled
Comment 6 Giovanni Campagna 2013-10-26 14:41:45 UTC
Review of attachment 257968 [details] [review]:

In all other cases (polkit, end session dialog) we just add "background-size: contain" to the specific styling, so we can do the same here.
Comment 7 sébastien lafargue 2013-10-27 11:44:22 UTC
Created attachment 258211 [details] [review]
scale correcty avatar image in loginDialog

you're right.

I probably forget to update the .css in my gnome-shell distro
and came into the foolish idea that changing style property
completly overwrite the styleclass
Comment 8 Piotr Drąg 2013-11-15 18:45:09 UTC
Which commit fixed this issue?
Comment 10 Piotr Drąg 2013-11-15 19:09:54 UTC
Thanks!