After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690442 - [waylandsink] Should not default to a fullscreen surface
[waylandsink] Should not default to a fullscreen surface
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal normal
: 1.0.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-18 18:47 UTC by Joe Konno
Modified: 2012-12-26 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not create a fullscreen canvas by default (1.04 KB, patch)
2012-12-18 18:48 UTC, Joe Konno 		committed Details | Review

Description Joe Konno 2012-12-18 18:47:09 UTC 
When the window is created, an extra call is made to explicitly make it fullscreen. This may not be ideal-- this should be deferred to the player or the Wayland compositor.

Attaching a patch. Basically, just remove that fullscreen function call.
Comment 1 Joe Konno 2012-12-18 18:48:07 UTC 
Created attachment 231825 [details] [review]
Do not create a fullscreen canvas by default

Proposed patch.
Comment 2 Tim-Philipp Müller 2012-12-23 16:13:08 UTC 
Thanks, but you could have attached that to the other bug ;) (bug #688190).

In future please create patches against git master or the git 1.0 branch. The 0.10 branch is no longer maintained, thanks!


commit aed2c7b4790053e881c0154953eef4265cb2318b
Author: Joe Konno <joe.konno@intel.com>
Date:   Tue Dec 18 09:53:16 2012 -0800

    waylandsink: do not default to a fullscreen canvas
    
    Defer certain canvas particulars to the player (or the Wayland
    compositor). Before this change, a fullscreen canvas was always
    requested. This may not be desirable in all cases.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690442
Comment 3 Joe Konno 2012-12-26 15:14:36 UTC 
I appreciate the feedback, Tim-Philipp, and will carry your advice forward to the next patch. Thanks for the commit! ^_^