GNOME Bugzilla – Bug 688190
waylandsink: Add a 'fullscreen' property
Last modified: 2018-05-06 13:16:10 UTC
It would be splendid if the waylandsink had a fullscreen property, as gstreamer-vaapi does: git://gitorious.org/vaapi/gstreamer-vaapi.git or, http://gitorious.org/vaapi/gstreamer-vaapi/blobs/master/gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
Created attachment 228907 [details] [review] [PATCH] wayland: Add support for non-fullscreen playback This adds a fullscreen property with which the playback can be made fullscreen or not. This changes the default behaviour *not* to be fullscreen which I think aligns better with most other sinks. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=688190 --- ext/wayland/gstwaylandsink.c | 47 +++++++++++++++++++++++++++++++++++++++++--- ext/wayland/gstwaylandsink.h | 2 ++ 2 files changed, 46 insertions(+), 3 deletions(-)
patch seems fine... +1
+1 from me, looks good (In reply to comment #1) > Created an attachment (id=228907) [details] [review] > [PATCH] wayland: Add support for non-fullscreen playback > > > This adds a fullscreen property with which the playback can be made fullscreen > or not. This changes the default behaviour *not* to be fullscreen which I > think aligns better with most other sinks. > > Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=688190 > --- > ext/wayland/gstwaylandsink.c | 47 +++++++++++++++++++++++++++++++++++++++++--- > ext/wayland/gstwaylandsink.h | 2 ++ > 2 files changed, 46 insertions(+), 3 deletions(-)
Hi Tim, do you think your could integrate this patch now that sreerenj has +1'ed it?
The issue is not so much a question of +1s, but whether we want to start adding fullscreen properties, which is something we have historically NACKed. Will need to discuss this first. (The issue itself remains of course).
Created attachment 231841 [details] [review] Practically the same patch, but for 0.10.x
Created attachment 231842 [details] [review] Practically the same patch, but for 0.10.x
Note: commit aed2c7b4790053e881c0154953eef4265cb2318b Author: Joe Konno <joe.konno@intel.com> Date: Tue Dec 18 09:53:16 2012 -0800 waylandsink: do not default to a fullscreen canvas Defer certain canvas particulars to the player (or the Wayland compositor). Before this change, a fullscreen canvas was always requested. This may not be desirable in all cases. https://bugzilla.gnome.org/show_bug.cgi?id=690442 so that leaves the question of the property.
It didn't take much mailing list searching to see just how worn this property discussion path is. The answer to the "may we have a fullscreen property for this/that sink?" appears to be, "no, implement in a player." Is there sufficient traction to continue pursuing this waylandsink property? (In reply to comment #5) > The issue is not so much a question of +1s, but whether we want to start adding > fullscreen properties, which is something we have historically NACKed. Will > need to discuss this first. (The issue itself remains of course).
This bug does not "block" anything, certainly not wayland support in GNOME. It's just a convenience interface/property/function at best.
Created attachment 287931 [details] [review] add fullscreen property We (STMicro) have done the same kind of patch for 1.4
Comment on attachment 231842 [details] [review] Practically the same patch, but for 0.10.x 0.10 is no longer supported.
Created attachment 346566 [details] [review] waylandsink-support-fullscreen This patch is the original patch ported to gst-1.11.1. Can we take the decision to accept this patch or to reject and close this ticket?
I thought this was nacked and long time buried ? (In reply to Tim-Philipp Müller from comment #5) > The issue is not so much a question of +1s, but whether we want to start > adding fullscreen properties, which is something we have historically > NACKed. Will need to discuss this first. (The issue itself remains of > course).
I'm happy to drop my objection to "fullscreen" properties on sinks. It's clearly something people want and that's useful, and no one else is likely to work on an alternative solution like an interface. Adding a property also doesn't prevent us from adding an interface in the future.
commit f777c66dcc29e3d9d6b56c85fdefc0600333aa0d (HEAD -> master, origin/master, origin/HEAD) Author: Fabien Dessenne <fabien.dessenne@st.com> Date: Thu Feb 23 11:48:13 2017 +0100 waylandsink: support fullscreen Add the fullscreen property that makes the sink displayed all across the output. https://bugzilla.gnome.org/show_bug.cgi?id=688190