After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688981 - support non-lsb distributions
support non-lsb distributions
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: sysinfo
unspecified
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
: 670266 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-24 17:31 UTC by Matthias Clasen
Modified: 2012-11-29 21:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.95 KB, patch)
2012-11-24 17:31 UTC, Matthias Clasen
reviewed Details | Review

Description Matthias Clasen 2012-11-24 17:31:16 UTC
Created attachment 229774 [details] [review]
patch

lsb_release may not be present, and in that case, we should read
/etc/os-release, which is present on all systemd-using distributions
and contains the information we need in an easy to parse format.
Comment 1 Robert Roth 2012-11-29 08:46:43 UTC
*** Bug 670266 has been marked as a duplicate of this bug. ***
Comment 2 Robert Roth 2012-11-29 08:54:29 UTC
Review of attachment 229774 [details] [review]:

The patch looks nice, clean and simple, I'll test it and commit it if it works ok (and it should work)
Comment 3 Robert Roth 2012-11-29 21:15:13 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.