After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688281 - Double tapping on a touchscreen does not open files/folders
Double tapping on a touchscreen does not open files/folders
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-13 19:46 UTC by Chris Wayne
Modified: 2013-03-08 20:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix_touchscreen_double_click_issue.patch (575 bytes, patch)
2013-02-14 16:57 UTC, James M. Leddy 		none Details | Review
eel-canvas: fix double tap with touchscreen devices (1023 bytes, patch)
2013-02-15 01:03 UTC, Cosimo Cecchi 		committed Details | Review

Description Chris Wayne 2012-11-13 19:46:55 UTC 
With a touchscreen (in this specific case Nexus 7, although it has been reproduced on x86 machines with touchscreen), double tapping a folder in nautilus does not open that folder as expected.  The same occurs when trying to double tap a file to open it.  

Expected results:
File/folder will be opened when double tapped

Actual results:
No action when double tapped
Comment 1 Cosimo Cecchi 2012-11-20 00:26:54 UTC 
Might be related to bug 667199 and bug 688017 (unfortunately I can't reproduce neither of those here).

I don't have any touchscreen hardware to try to reproduce this bug; a patch would be awesome.
Comment 2 James M. Leddy 2013-02-14 16:57:57 UTC 
Created attachment 236103 [details] [review]
fix_touchscreen_double_click_issue.patch

We have a patch that is supposed to fix the problem.
Comment 3 Cosimo Cecchi 2013-02-15 01:03:13 UTC 
Created attachment 236201 [details] [review]
eel-canvas: fix double tap with touchscreen devices

Code here is not doing what the comment (and the symmetric part in
the RELEASE case) says.
Comment 4 Cosimo Cecchi 2013-02-15 01:04:35 UTC 
The EelCanvas event code hasn't been touched in a long time - it looks to me like the patch I attached is an equivalent, but cleaner, fix for the same problem.

Can you please test if this patch solves the issue for you? Thanks
Comment 5 Sebastien Bacher 2013-03-08 17:53:32 UTC 
I can confirm the patch fixes the issue (applied on nautilus 3.6)
Comment 6 Cosimo Cecchi 2013-03-08 20:28:56 UTC 
Attachment 236201 [details] pushed as d486af2 - eel-canvas: fix double tap with touchscreen devices

Thanks, I pushed it to master now.