After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688020 - stop using gnome-terminal's gconf profiles
stop using gnome-terminal's gconf profiles
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: terminal
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Naba Kumar
Anjuta maintainers
: 666403 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-09 22:40 UTC by Christian Persch
Modified: 2014-05-06 17:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update part of terminal plugin to gsettings (3.66 KB, patch)
2014-02-20 04:17 UTC, Tristian Celestin
none Details | Review
Patch to update terminal plugin to use gsettings profiles (57.01 KB, patch)
2014-03-03 01:16 UTC, Tristian Celestin
none Details | Review
Patch to update terminal plugin to use gsettings profiles (58.98 KB, patch)
2014-03-03 06:23 UTC, Tristian Celestin
none Details | Review

Description Christian Persch 2012-11-09 22:40:40 UTC
Just saw that anjuta reads g-t's gconf prefs. g-t is being ported to gsettings (bug 624856, hopefully done soon once gsettingslist exists), so these keys will become useless.
Comment 1 Christian Persch 2012-11-09 22:42:16 UTC
Well, I missed the #if 0 :-).
Comment 2 Tristian Celestin 2014-02-09 12:34:15 UTC
I have started porting the anjuta terminal plugin to gsettings. Is there a way to apply a specific profile to a terminal through gsettings? There is current code that attempts to do this in the method on_pref_profile_changed in terminal.c, but the referenced key dies not exist.
Comment 3 Tristian Celestin 2014-02-20 04:17:22 UTC
Created attachment 269755 [details] [review]
Update part of terminal plugin to gsettings

This is an initial stab at converting some of the remaining referenced gconf keys to gsettings. Uncommenting the #if 0 block in ipreferences_merge will cause the profile combo box to display the UUIDs associated with each profile defined in gnome-terminal.

I'm not sure how to proceed further, as I'm uncertain whether gsettings exposes replacement key/value pairs for all the gconf pairs currently referenced.
Comment 4 Christian Persch 2014-02-20 21:00:40 UTC
See gnome-terminal/src/migration.c for how the gsettings keys relate to the previous gconf keys, and gnome-terminal/src/terminal-screen.c:terminal_screen_profile_changed_cb() for how to use those gsettings keys.  Might also be worth copypasting src/terminal-settings-list.[ch] and src/terminal-profiles-list.[ch] which encapsulate working with the gsettings profiles.
Comment 5 Tristian Celestin 2014-03-03 01:16:07 UTC
Created attachment 270737 [details] [review]
Patch to update terminal plugin to use gsettings profiles

The attached patch does the following:

1. Updates the terminal-plugin gsettings schema to store the last selected profile
2. Updates the terminal-plugin to access profiles using gsettings instead of gconf
3. Updates the preferences UI to display the name and UUID of the selected profile
Comment 6 Tristian Celestin 2014-03-03 06:23:48 UTC
Created attachment 270757 [details] [review]
Patch to update terminal plugin to use gsettings profiles

Fixed bug that prevented palette from being applied and added name to header
Comment 7 Sébastien Granjoux 2014-03-08 07:20:21 UTC
Thank you for you work.

I have committed your patches without any changes except the patch 8 which is the same than the patch 1 and the patch 9 which is already included in another patch.
Comment 8 Sébastien Granjoux 2014-05-06 17:19:56 UTC
*** Bug 666403 has been marked as a duplicate of this bug. ***