After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687788 - metadata-store: Add 'search' with filtering by 'favourite'
metadata-store: Add 'search' with filtering by 'favourite'
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on: 685861 686288
Blocks:
 
 
Reported: 2012-11-06 17:19 UTC by Antía Puentes
Modified: 2012-11-16 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (7.39 KB, patch)
2012-11-06 17:19 UTC, Antía Puentes
none Details | Review
metadata-store: Added filtering by 'favourite' (8.12 KB, patch)
2012-11-15 15:53 UTC, Juan A. Suarez Romero
committed Details | Review

Description Antía Puentes 2012-11-06 17:19:35 UTC
Created attachment 228297 [details] [review]
Proposed patch

Add the search operation in the metadata-store plugin. The search operation should allow key filtering by 'favourite'.
Comment 1 Antía Puentes 2012-11-06 17:21:28 UTC
The patch implements the 'search' operation without text filtering, as imho this doesn't make sense in the current database schema.
Comment 2 Juan A. Suarez Romero 2012-11-13 18:51:37 UTC
The patch is bitrotten. I'm fixing it
Comment 3 Juan A. Suarez Romero 2012-11-15 15:53:05 UTC
Created attachment 229061 [details] [review]
metadata-store: Added filtering by 'favourite'

Implements the 'search' operation without text filtering,
because it doesn't make sense in the current database
schema.

Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Comment 4 Juan A. Suarez Romero 2012-11-16 09:50:03 UTC
commit 5b01de64209437d088f3ce9e82e27154c6b17c6b
Author: Antía Puentes <apuentes@igalia.com>
Date:   Tue Nov 13 18:53:57 2012 +0000

    metadata-store: Added filtering by 'favourite'
    
    Implements the 'search' operation without text filtering,
    because it doesn't make sense in the current database
    schema.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=687788
    
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 src/metadata-store/grl-metadata-store.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 159 insertions(+), 11 deletions(-)