After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685861 - Add GRL_METADATA_KEY_FAVOURITE
Add GRL_METADATA_KEY_FAVOURITE
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal enhancement
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks: 686288 687788
 
 
Reported: 2012-10-10 08:09 UTC by Antía Puentes
Modified: 2012-11-06 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for boolean data in GrlData (2.62 KB, patch)
2012-10-10 10:37 UTC, Antía Puentes
needs-work Details | Review
Add the 'favourite' metadata property (3.91 KB, patch)
2012-10-10 10:38 UTC, Antía Puentes
none Details | Review
Add the 'favourite' metadata property v2 (3.91 KB, patch)
2012-10-17 11:23 UTC, Antía Puentes
committed Details | Review
Add support for boolean data in GrlData v2 (2.69 KB, patch)
2012-10-19 09:12 UTC, Juan A. Suarez Romero
committed Details | Review

Description Antía Puentes 2012-10-10 08:09:44 UTC
This key would indicate if the user has marked an item as favourite or not.

It would be supported only in some plugins, like the metadata-store.
Comment 1 Antía Puentes 2012-10-10 10:37:50 UTC
Created attachment 226162 [details] [review]
Add support for boolean data in GrlData
Comment 2 Antía Puentes 2012-10-10 10:38:33 UTC
Created attachment 226163 [details] [review]
Add the 'favourite' metadata property
Comment 3 Antía Puentes 2012-10-17 11:23:30 UTC
Created attachment 226628 [details] [review]
Add the 'favourite' metadata property v2
Comment 4 Juan A. Suarez Romero 2012-10-19 08:31:46 UTC
Review of attachment 226162 [details] [review]:

::: src/data/grl-data.c
@@ +360,3 @@
+ * grl_data_set_boolean:
+ * @data: data to change
+ * @key: (type GObject.ParamSpec): key to change or add

type is GrlKeyID

@@ +379,3 @@
+ * grl_data_get_boolean:
+ * @data: data to inspect
+ * @key (type GObject.ParamSpec): key to use

type is GrlKeyID
Comment 5 Juan A. Suarez Romero 2012-10-19 09:12:00 UTC
Created attachment 226800 [details] [review]
Add support for boolean data in GrlData v2

Address the issues commented
Comment 6 Juan A. Suarez Romero 2012-10-19 09:19:40 UTC
commit 47dc2a401577edf80b3521dff478c2aa687c38ba
Author: Ant<C3><AD>a Puentes <apuentes@igalia.com>
Date:   Wed Oct 10 12:17:35 2012 +0200

    core: Add the 'favourite' metadata property
    
    The new property indicates if an item was marked as
    favourite or not.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=685861

 src/data/grl-media.c   |   29 +++++++++++++++++++++++++++++
 src/data/grl-media.h   |    4 ++++
 src/grl-metadata-key.c |    9 +++++++++
 src/grl-metadata-key.h |    1 +
 4 files changed, 43 insertions(+)

commit 6269a37296d3021bc4b8f602130e6e1c37d8ab3f
Author: Ant<C3><AD>a Puentes <apuentes@igalia.com>
Date:   Wed Oct 10 12:17:23 2012 +0200

    core: Add support for boolean data in GrlData
    
    https://bugzilla.gnome.org/show_bug.cgi?id=685861
    
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 src/data/grl-data.c |   41 +++++++++++++++++++++++++++++++++++++++++
 src/data/grl-data.h |    4 ++++
 2 files changed, 45 insertions(+)