After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687121 - When searching for desktop launchers, also use GenericName and FullName fields of the desktop file
When searching for desktop launchers, also use GenericName and FullName field...
Product: gnome-shell
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
Depends on:
Reported: 2012-10-29 14:49 UTC by Elad Alfassa
Modified: 2012-11-30 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (2.42 KB, patch)
2012-10-29 15:13 UTC, Matthias Clasen
needs-work Details | Review
better patch (2.45 KB, patch)
2012-10-29 15:24 UTC, Matthias Clasen
accepted-commit_now Details | Review

Description Elad Alfassa 2012-10-29 14:49:18 UTC
See bug #685824 for details.
Comment 1 Matthias Clasen 2012-10-29 15:01:56 UTC
I don't think FullName is too useful - it is largely '<Name> <GenericName>'  modulo translation and rearrangement.

But GenericName will help a lot for terms such as browser, debugger, spreadsheet.
Comment 2 Matthias Clasen 2012-10-29 15:13:46 UTC
Created attachment 227542 [details] [review]
Comment 3 Florian Müllner 2012-10-29 15:20:19 UTC
Review of attachment 227542 [details] [review]:

::: src/shell-app.c
@@ +1405,3 @@
+                current_match = MATCH_PREFIX;
+              else
+                current_match = MATCH_SUBSTRING;

If we have a prefix match on name, but only a substring match on generic name, the match is degraded to SUBSTRING.
Comment 4 Matthias Clasen 2012-10-29 15:24:28 UTC
Created attachment 227544 [details] [review]
better patch
Comment 5 Florian Müllner 2012-10-29 15:27:50 UTC
Review of attachment 227544 [details] [review]:

Looks good, thanks!
Comment 6 Matthias Clasen 2012-10-29 15:51:00 UTC
I think this should go to 3.6 too
Comment 7 Matthias Clasen 2012-10-29 15:51:35 UTC
Pushed to master
Comment 8 Matthias Clasen 2012-10-29 15:52:40 UTC
...and to 3.6 too
Comment 9 Allan Day 2012-11-30 14:40:48 UTC
This seems wrong to me. See bug 689345 and bug 682529.

The correct fix to bug 685824 would have been to add the keyword to the desktop file, as Florian pointed out:
Comment 10 Allan Day 2012-11-30 15:38:21 UTC
(In reply to comment #9)
> This seems wrong to me.

Ignore me. It seems fine. See