After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686182 - [GES] No dialog to install missing codecs after discovering clips
[GES] No dialog to install missing codecs after discovering clips
Status: RESOLVED OBSOLETE
Product: pitivi
Classification: Other
Component: Media library
0.91
Other Linux
: Normal normal
: 0.95
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on: 686181 720596
Blocks: 629205 629206
 
 
Reported: 2012-10-15 21:14 UTC by Jean-François Fortin Tam
Modified: 2015-10-20 13:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
project: Add misc information about error in the 'error-loading' signal (4.46 KB, patch)
2013-12-17 10:25 UTC, Thibault Saunier
rejected Details | Review

Description Jean-François Fortin Tam 2012-10-15 21:14:43 UTC
Pitivi used to have such a dialog, but it doesn't get triggered in the GES version. Depends on bug #686181 in GES.
Comment 1 Jean-François Fortin Tam 2013-01-30 17:39:52 UTC
Partially done in https://github.com/nekohayo/pitivi/commits/codecs-installer but blocked on missing/erroneous stuff from GES.
Comment 2 Thibault Saunier 2013-10-14 15:43:09 UTC
> [Comment #1] nekohayo@gmail.com : 20130130T17:39:52
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Partially done in https://github.com/nekohayo/pitivi/commits/codecs-installer but blocked on missing/erroneous stuff from GES.

Jeff it would be great if you could be a bit more precise about what is missing/going wrong, I have to say I can't remember that at all.
Comment 3 Jean-François Fortin Tam 2013-12-17 02:39:04 UTC
Ok, rebased the branch now. I at least get the error signal from gst... the first question that comes to mind now is how do I get the detail string to be used with GstPbutils's "install_plugins_async" function.

In theory, you get that detail strying by using
missing_plugin_message_get_installer_detail()

...on a gst error.

However, the "error-loading-asset" signal emitted by GES gives me a GError, which is just a string message such as
"Il manque un greffon dans votre installation de GStreamer."

...instead of what I thought would have been a gst core error object or something. So how do I use that with missing_plugin_message_get_installer_detail() ?
Comment 4 Jean-François Fortin Tam 2013-12-17 02:43:30 UTC
...and actually, if you had looked at the GES bug report marked as blocking this one, you would have seen the exact same explanation:

https://bugzilla.gnome.org/show_bug.cgi?id=686181#c1
Comment 5 Thibault Saunier 2013-12-17 10:25:57 UTC
Created attachment 264402 [details] [review]
project: Add misc information about error in the 'error-loading' signal
Comment 6 Thibault Saunier 2013-12-17 11:23:46 UTC
You should do Gst.
Comment 7 Thibault Saunier 2013-12-17 11:24:50 UTC
(In reply to comment #6)
> You should do Gst.

Sorry my mistake. I just made that bug depend on https://bugzilla.gnome.org/show_bug.cgi?id=720596 instead of explaining it here.
Comment 8 Jean-François Fortin Tam 2014-03-14 14:47:23 UTC
Comment on attachment 264402 [details] [review]
project: Add misc information about error in the 'error-loading' signal

Marking that patch as rejected (so that it comes off the patch review queue), as I suppose you remixed it into some other patch in bug #720596
Comment 9 Thibault Saunier 2015-10-20 13:07:42 UTC
This bug has been migrated to https://phabricator.freedesktop.org/T2989.

Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi.

See http://wiki.pitivi.org/wiki/Bug_reporting for details.