After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685983 - [PATCH] Libburnia plugin: Fix while loop in `brasero_libisofs_write_image_to_fd_thread()`
[PATCH] Libburnia plugin: Fix while loop in `brasero_libisofs_write_image_to_...
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: libbrasero-burn
3.4.x
Other Linux
: Normal critical
: ---
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-11 15:37 UTC by Paul Menzel
Modified: 2012-10-13 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Libburnia plugin: Fix while loop in `brasero_libisofs_write_image_to_fd_thread()` (#685983) (2.68 KB, patch)
2012-10-11 15:39 UTC, Paul Menzel
committed Details | Review

Description Paul Menzel 2012-10-11 15:37:32 UTC
This issue is tracked in the Debian BTS as 688229. The commit fixing bug 630651 introduced an error causing all mediums to be corrupt when burning on the fly.

[…]
BraseroBurn: (at burn-checksum-image.c:531) BraseroChecksumImage Setting new checksum (type = 2) f3c3f005e20f1105aa9c332ba005221d (file:///tmp/brasero_tmp_8A05LW.md5 before)
BraseroBurn: (at burn-job.c:1071) BraseroChecksumImage Finished track successfully
BraseroBurn: (at burn-task-ctx.c:354) No next track to process
BraseroBurn: (at burn-job.c:862) BraseroChecksumImage disconnecting BraseroChecksumImage from BraseroLibburn
BraseroBurn: (at burn-job.c:881) BraseroChecksumImage closing connection for BraseroChecksumImage
BraseroBurn: (at burn-job.c:258) BraseroChecksumImage deactivating
BraseroBurn: (at burn-libburn-common.c:218) BraseroLibburn Premature end of input encountered. Missing: 48709632 bytes
BraseroBurn: (at burn-job.c:1787) BraseroLibburn called brasero_job_get_session_output_size
BraseroBurn: (at burn-job.c:1858) BraseroLibburn called brasero_job_set_current_action
BraseroBurn: (at burn-libburn-common.c:218) BraseroLibburn syncing cache (stdio fsync)
BraseroBurn: (at burn-libburn.c:852) BraseroLibburn Something went wrong
BraseroBurn: (at burn-job.c:1138) BraseroLibburn called brasero_job_error
BraseroBurn: (at burn-job.c:1140) BraseroLibburn finished with an error
BraseroBurn: (at burn-job.c:1174) BraseroLibburn asked to stop because of an error
        error           = 15
        message = "Ein Fehler trat beim Beschreiben der CD/DVD auf"
[…]

As I am not sure if this is the same bug as bug 655601 I create a new ticket and attach the patch here.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688229
Comment 1 Paul Menzel 2012-10-11 15:39:35 UTC
Created attachment 226272 [details] [review]
[PATCH] Libburnia plugin: Fix while loop in `brasero_libisofs_write_image_to_fd_thread()` (#685983)

This is the patch fixing this problem for me and others.

1. Please apply this to *all* versions since 3.x as otherwise burning on the fly does not work.
2. Without Thomas Schmitt and Michael Biebl this patch would not exist. So please consider donating to the libburnia project [1] (and to Debian and GNOME).
3. I hope everything works now. ;-)

[1] http://libburnia-project.org/
Comment 2 André Klapper 2012-10-11 17:10:42 UTC
(In reply to comment #1)
> 1. Please apply this to *all* versions since 3.x

3.0 and 3.2 are ancient and I don't see much sense in that. Maybe 3.4. In general Brasero is rather understaffed so not much happening.
Comment 3 Colin Walters 2012-10-13 13:08:01 UTC
Review of attachment 226272 [details] [review]:

Wow, that's an epic commit message.  Anyways, the patch looks right to me.