After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685863 - Export locale categories through D-Bus
Export locale categories through D-Bus
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks: 647373
 
 
Reported: 2012-10-10 09:04 UTC by Bastien Nocera
Modified: 2012-11-07 12:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remember the original envvars when set over D-Bus (1.89 KB, patch)
2012-10-10 09:04 UTC, Bastien Nocera
none Details | Review
Export original envvar's values through D-Bus (3.53 KB, patch)
2012-10-10 09:04 UTC, Bastien Nocera
none Details | Review
Export original envvar's values through D-Bus (3.51 KB, patch)
2012-10-11 07:34 UTC, Bastien Nocera
none Details | Review
Export envvars value through D-Bus (3.50 KB, patch)
2012-10-11 07:34 UTC, Bastien Nocera
none Details | Review
Export locale categories through D-Bus (4.33 KB, patch)
2012-11-02 15:01 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2012-10-10 09:04:19 UTC
.
Comment 1 Bastien Nocera 2012-10-10 09:04:21 UTC
Created attachment 226158 [details] [review]
Remember the original envvars when set over D-Bus
Comment 2 Bastien Nocera 2012-10-10 09:04:42 UTC
Created attachment 226159 [details] [review]
Export original envvar's values through D-Bus

Add Getenv() function for System Settings to lookup the original
value of a particular variable, such as the session language.
Comment 3 Bastien Nocera 2012-10-10 09:05:47 UTC
Patches are only compile tested right now. They should allow implementing the ideas in bug 647373.
Comment 4 Ray Strode [halfline] 2012-10-10 17:42:27 UTC
Why the word "original"? It's not the original environment gnome-session was started with, it's the environment gnome-session currently has. Also, why the separate hash table instead of just using g_getenv ?
Comment 5 Bastien Nocera 2012-10-11 07:34:28 UTC
Created attachment 226231 [details] [review]
Export original envvar's values through D-Bus

Add Getenv() function for System Settings to lookup the value
of a particular environment variable, such as the session language.
Comment 6 Bastien Nocera 2012-10-11 07:34:59 UTC
Created attachment 226232 [details] [review]
Export envvars value through D-Bus

Add Getenv() function for System Settings to lookup the value
of a particular environment variable, such as the session language.
Comment 7 Bastien Nocera 2012-10-11 07:36:07 UTC
(In reply to comment #4)
> Why the word "original"? It's not the original environment gnome-session was
> started with, it's the environment gnome-session currently has. Also, why the
> separate hash table instead of just using g_getenv ?

You're right, seeing as we can't change those values after the initialisation phase. Simplified the code, and changed the text to not mention "original".
Comment 8 Ray Strode [halfline] 2012-10-15 18:15:44 UTC
Comment on attachment 226232 [details] [review]
Export envvars value through D-Bus

talked with hadess about this on IRC. he's going to use setlocale(LC_MESSAGES, NULL) from the panel instead to avoid the unnecessary IPC, and having to deal with inheritance.
Comment 9 Bastien Nocera 2012-11-02 15:01:48 UTC
Created attachment 227898 [details] [review]
Export locale categories through D-Bus

Add GetLocale() function for System Settings to lookup the value
of a particular locale setting, such as the session language.