After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647373 - Add logout button in selected language
Add logout button in selected language
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.0.x
Other Linux
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 678567 683252 (view as bug list)
Depends on: 685863
Blocks:
 
 
Reported: 2011-04-10 19:32 UTC by Andreas Tunek
Modified: 2012-12-10 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mockup for logout button (48.25 KB, image/png)
2011-04-11 19:06 UTC, Andreas Tunek
  Details
region: Offer logout option after changing language (13.00 KB, patch)
2012-09-26 14:56 UTC, Bastien Nocera
committed Details | Review
button (26.00 KB, image/png)
2012-09-26 15:03 UTC, Bastien Nocera
  Details
region: Use log out button in future language (1.48 KB, patch)
2012-09-26 15:05 UTC, Bastien Nocera
none Details | Review
screenshot with target language (25.85 KB, image/png)
2012-09-26 15:08 UTC, Bastien Nocera
  Details
region: Use log out button in future language (1.55 KB, patch)
2012-09-26 15:28 UTC, Bastien Nocera
committed Details | Review

Description Andreas Tunek 2011-04-10 19:32:25 UTC
It is difficult for the user to figure out how change language of the user interface. 

The video in the link is a user using Gnome 3 for the first time and tries to change to language of the user interface. This is not as easy as it should be.
http://www.youtube.com/watch?v=NDl-UKmTFmM
Comment 1 Bastien Nocera 2011-04-10 19:34:26 UTC
I'm not sure what's too hard about it, apart from the need to log-out/log back in which should be spelt out.

You can change it both in the user accounts panel, and in the "region & language" panel.
Comment 2 Andreas Tunek 2011-04-11 19:06:35 UTC
Created attachment 185747 [details]
Mockup for logout button
Comment 3 Andreas Tunek 2011-04-11 19:06:58 UTC
I do not think it is hard either, but the user in the video could not understand how to do it. Maybe we could add a "Log out" button that becomes available when you change language.

I appended a very ugly mockup.
Comment 4 Bastien Nocera 2011-04-13 10:33:36 UTC
The user in the video didn't actually read the one line of text completely, to be honest.

Let's see about adding a logout button.
Comment 5 Andreas Tunek 2011-04-14 19:55:31 UTC
Normal users never read the text you write :)

But a button would be most appreciated.
Comment 6 Bastien Nocera 2011-04-14 20:03:26 UTC
A friend of mine mentioned that the "Log out" button should be in the selected language, which I think is a great idea.
Comment 7 Andreas Tunek 2011-04-21 21:45:58 UTC
Yeah, then you get something like an animation as well when you change language!
Comment 8 William Jon McCann 2011-04-28 20:20:36 UTC
We should really just make it change dynamically.  Anything else is just confusing.
Comment 9 Andreas Tunek 2011-05-01 20:25:22 UTC
Tried another first time Gnome3 user, he did not understand that he had to log out either. I also think that changing languages directly is the best if that is technically possible.
Comment 10 Andreas Tunek 2011-07-02 18:14:58 UTC
Any work on this for 3.2?
Comment 11 Jakub Steiner 2011-07-22 17:04:38 UTC
I agree having instant apply is the proper solution. But let's improve us being wrong here.

The current way really makes no effort to communicate you need to log out. The log out button is an improvement. It would be great if we could hint that language to GDM while we're logging people out though. Authorization being still in the default language keeps the user in doubt if it actually worked. Or maybe a way to restart a session without the need to authorize. In any case having that button would certainly improve the wrongness of 3.0.
Comment 12 Bastien Nocera 2012-09-06 13:46:30 UTC
*** Bug 683252 has been marked as a duplicate of this bug. ***
Comment 13 Bastien Nocera 2012-09-26 14:56:49 UTC
Created attachment 225212 [details] [review]
region: Offer logout option after changing language
Comment 14 Bastien Nocera 2012-09-26 15:03:21 UTC
Created attachment 225213 [details]
button
Comment 15 Bastien Nocera 2012-09-26 15:05:54 UTC
Created attachment 225214 [details] [review]
region: Use log out button in future language
Comment 16 Bastien Nocera 2012-09-26 15:08:28 UTC
Created attachment 225216 [details]
screenshot with target language

Using "French (Colloquial)" as the target language ;)
Comment 17 Bastien Nocera 2012-09-26 15:28:29 UTC
Created attachment 225221 [details] [review]
region: Use log out button in future language
Comment 18 Matthias Clasen 2012-09-27 00:52:20 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=855697 is a bug where this (a logout button) is requested for livecd scenarios)
Comment 19 Volker Sobek (weld) 2012-09-27 07:09:48 UTC
Also notice that the new language and the log out button are forgotten once you close control-center or go back to the control-center-overview.

If the user misses the button the first try (and yes, this will happen!;)) and opens the language panel again to check why the language didn't change, it shows the old language selected and no log out button. But he would get the new language anyway after logging out and back in, even if he wouldn't change the language again. This is really broken.

Also, the log out button could be hidden again when you select the current language.
Comment 20 Bastien Nocera 2012-09-27 14:35:18 UTC
(In reply to comment #19)
> Also notice that the new language and the log out button are forgotten once you
> close control-center or go back to the control-center-overview.

That's problem because we don't track the original language that the session used.

> If the user misses the button the first try (and yes, this will happen!;)) and
> opens the language panel again to check why the language didn't change, it
> shows the old language selected and no log out button. But he would get the new
> language anyway after logging out and back in, even if he wouldn't change the
> language again.

I think the original paragraph was enough explanations.

>This is really broken.

That's not helpful.

> Also, the log out button could be hidden again when you select the current
> language.

Again, same bug. We need to track the original language of the session to be able to do that.
Comment 21 Bastien Nocera 2012-11-23 17:53:07 UTC
Attachment 225212 [details] pushed as fca58d0 - region: Offer logout option after changing language
Attachment 225221 [details] pushed as 1cfc469 - region: Use log out button in future language
Comment 22 Bastien Nocera 2012-11-23 17:53:40 UTC
And it's all fixed now.

commit 96247c61871ec64712f66d30606208a7772e383d
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Nov 23 18:51:21 2012 +0100

    region: And remember to show the logout button if launched again
    
    https://bugzilla.gnome.org/show_bug.cgi?id=647373

commit 3eb6cdd1bc26d178d3557585fefe9a9d9eaae632
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Nov 23 18:44:58 2012 +0100

    common: Try to get the configured language as the current one

commit 781bda8e12bee4eb827b82a606c2b160a34128e3
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Nov 23 18:42:32 2012 +0100

    common: Split out getting the lang for a user
    
    Into get_lang_for_user(), so it can be reused internally.

commit 4099b547a7d6b4d19bda09f09af2bf83f5efa20e
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Nov 23 18:28:07 2012 +0100

    region: Don't offer logout button if we revert the language
    
    If the language selected is the language that was originally
    the session language, don't offer to log out.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=647373
Comment 23 Bastien Nocera 2012-12-10 14:29:23 UTC
*** Bug 678567 has been marked as a duplicate of this bug. ***