After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685567 - Remove creation of automatic input sources based on LC_CTYPE
Remove creation of automatic input sources based on LC_CTYPE
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
3.10
Depends on: 685386
Blocks:
 
 
Reported: 2012-10-05 14:31 UTC by Rui Matos
Modified: 2013-05-27 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Don't hard-code per-locale default IBus engines (4.08 KB, patch)
2013-04-18 09:14 UTC, Daiki Ueno 		none Details | Review
keyboard: Stop adding locale based input sources from a hardcoded list (3.24 KB, patch)
2013-05-09 15:37 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-10-05 14:31:20 UTC 
Commit 2c1f88690f0ba54bfc45c425ef1f857d1202578c should be reverted when bug 685386 gets implemented.
Comment 1 Daiki Ueno 2013-04-18 09:14:58 UTC 
Created attachment 241804 [details] [review]
keyboard: Don't hard-code per-locale default IBus engines

Each distribution has its own preferences on default IBus engines.
This patch switches the per-locale engine configuration to gsettings,
so that it can be modified with vender overrides.
--
Sorry if you are already working on this, but this is just a possibility.
gsettings-desktop-schemas needs change of course.
Comment 2 Rui Matos 2013-05-09 15:37:58 UTC 
Created attachment 243717 [details] [review]
keyboard: Stop adding locale based input sources from a hardcoded list

This was never meant to be the definite way to do it and we now have
gnome-initial-setup which is a better place to do this.
--

g-i-s is taking over this responsibility, see bug 699501.
Comment 3 Bastien Nocera 2013-05-17 14:01:37 UTC 
Review of attachment 243717 [details] [review]:

Looks good for master.
Comment 4 Rui Matos 2013-05-27 16:15:00 UTC 
Comment on attachment 243717 [details] [review]
keyboard: Stop adding locale based input sources from a hardcoded list

Pushed https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=912c41a1b729d635d3b335c87653141781e9be9e