After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685479 - build system not linking binaries properly
build system not linking binaries properly
Status: RESOLVED OBSOLETE
Product: rygel
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-04 08:58 UTC by Andreas Henriksson
Modified: 2013-02-19 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Drop-unused-libs-from-librygel-core.patch (1.15 KB, patch)
2012-10-04 09:57 UTC, Andreas Henriksson
committed Details | Review
0002-Move-rygel-base-libs-up-the-linking-chain-to-avoid-e.patch (1.39 KB, patch)
2012-10-04 09:57 UTC, Andreas Henriksson
committed Details | Review
0003-Expand-LIBADDs-to-everything-needed.patch (5.38 KB, patch)
2012-10-04 09:58 UTC, Andreas Henriksson
committed Details | Review
0004-Fix-typo-in-librygel-core-Makefile.am-GIO_LIBS-vs-LI.patch (781 bytes, patch)
2012-10-04 09:58 UTC, Andreas Henriksson
committed Details | Review
0005-LIBGUPNP_DLNA_LIBS-is-already-part-of-RYGEL_COMMON_S.patch (813 bytes, patch)
2012-10-04 09:58 UTC, Andreas Henriksson
none Details | Review
0006-Move-UUID_LIBS-to-where-it-s-actually-used.patch (1.50 KB, patch)
2012-10-04 09:59 UTC, Andreas Henriksson
committed Details | Review
0007-Move-GSTREAMER_BASE_LIBS-to-librygel-server-LIBADD.patch (1.19 KB, patch)
2012-10-04 09:59 UTC, Andreas Henriksson
none Details | Review

Description Andreas Henriksson 2012-10-04 08:58:29 UTC
When building rygel in debian, the packaging tools gives alot of warnings about binaries being uselessly linked to libraries it doesn't use, and thus causing extra package dependencies (and runtime/startup overhead?).

A big source of this is the convenience "groups" in common.am which is used in different parts of rygel but doesn't actually match what is often needed. Also there are some places which simply links to libraries not needed.
Comment 1 Andreas Henriksson 2012-10-04 08:58:37 UTC
There is also a problem of rygel not linking to libraries it does use!
A separate bug has been filed for that, see Bug #685478
Comment 2 Andreas Henriksson 2012-10-04 09:57:41 UTC
Created attachment 225790 [details] [review]
0001-Drop-unused-libs-from-librygel-core.patch
Comment 3 Andreas Henriksson 2012-10-04 09:57:55 UTC
Created attachment 225791 [details] [review]
0002-Move-rygel-base-libs-up-the-linking-chain-to-avoid-e.patch
Comment 4 Andreas Henriksson 2012-10-04 09:58:09 UTC
Created attachment 225792 [details] [review]
0003-Expand-LIBADDs-to-everything-needed.patch
Comment 5 Andreas Henriksson 2012-10-04 09:58:24 UTC
Created attachment 225793 [details] [review]
0004-Fix-typo-in-librygel-core-Makefile.am-GIO_LIBS-vs-LI.patch
Comment 6 Andreas Henriksson 2012-10-04 09:58:44 UTC
Created attachment 225794 [details] [review]
0005-LIBGUPNP_DLNA_LIBS-is-already-part-of-RYGEL_COMMON_S.patch
Comment 7 Andreas Henriksson 2012-10-04 09:59:00 UTC
Created attachment 225795 [details] [review]
0006-Move-UUID_LIBS-to-where-it-s-actually-used.patch
Comment 8 Andreas Henriksson 2012-10-04 09:59:19 UTC
Created attachment 225796 [details] [review]
0007-Move-GSTREAMER_BASE_LIBS-to-librygel-server-LIBADD.patch
Comment 9 Andreas Henriksson 2012-10-04 10:01:44 UTC
1-7 are the first set of patches (not solving the problem entirely, but getting the easy stuff and worst offenders causing multiple binaries to get uselessly linked) not fixing all of the uselessly linked libraries, but a good start.
Comment 10 Jens Georg 2012-10-06 16:19:09 UTC
Most of them are applied to master now, 0.16 to follow
Comment 11 Jens Georg 2012-12-15 20:38:22 UTC
Comment on attachment 225794 [details] [review]
0005-LIBGUPNP_DLNA_LIBS-is-already-part-of-RYGEL_COMMON_S.patch

Think this is not necessary anymore
Comment 12 Jens Georg 2013-02-19 15:09:39 UTC
I think that's either fixed or obsoleted by the build system changes