After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685478 - build system not linking to used libraries, relies on gupnp leaking linker flags
build system not linking to used libraries, relies on gupnp leaking linker flags
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
0.16.x
Other Linux
: Normal minor
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-04 08:57 UTC by Andreas Henriksson
Modified: 2012-10-12 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix build (1.63 KB, patch)
2012-10-07 00:33 UTC, Andreas Henriksson
committed Details | Review
modules link needed libs (2.72 KB, patch)
2012-10-07 00:33 UTC, Andreas Henriksson
committed Details | Review
librygel-* links needed libs (2.27 KB, patch)
2012-10-07 00:34 UTC, Andreas Henriksson
committed Details | Review

Description Andreas Henriksson 2012-10-04 08:57:04 UTC
Rygel uses gssdp and gio directly but doesn't link against them through the build system explicitly. Instead rygel relies on gupnp "leaking" the needed linker flags to gssdp and gio.

If the pkg-config flags in gupnp gets fixed up to not leak the linker flags (see #685477 ) then rygel will fail to build.
Comment 1 Andreas Henriksson 2012-10-04 10:05:28 UTC
Patch 0003 in Bug #685479 fixes this problem (but since it's 0003 and not 0001, it doesn't apply standalone.... should be easy enough to understand what's needed though).
It would probably be a good idea to get this patch to apply alone, so it can be included in the 0.16 series....
Comment 2 Andreas Henriksson 2012-10-07 00:33:31 UTC
Created attachment 225964 [details] [review]
fix build
Comment 3 Andreas Henriksson 2012-10-07 00:33:51 UTC
Created attachment 225965 [details] [review]
modules link needed libs
Comment 4 Andreas Henriksson 2012-10-07 00:34:13 UTC
Created attachment 225966 [details] [review]
librygel-* links needed libs
Comment 5 Andreas Henriksson 2012-10-07 00:37:14 UTC
the above patches apply on top of the rygel-0-16 branch (head at 76042d3e1e28ebfcd9bcc7666efa15fc8558385c). This makes rygel 0.16 build on top of a gupnp stack which has all pkg-config files modified to use Requires.private instead of Requires. Hopefully this will make sure rygel 0.16 builds on top of future versions of the gupnp stack (given that there are no other incompatibilities that prevent that).
Comment 6 Jens Georg 2012-10-07 07:44:55 UTC
It can't be build from vala against GUPnP 0.19. The GUPnP vapi is slightly incompatible because the old one contained a work-around for a work-around. There's a patch on master to change that, but I don't want to apply it to 0.16.
Comment 7 Jens Georg 2012-10-07 08:56:12 UTC
What's the difference of applying the old series of patches and the new one?
Comment 8 Andreas Henriksson 2012-10-07 14:49:02 UTC
(In reply to comment #7)
> What's the difference of applying the old series of patches and the new one?

These patches are the same as "patch no. 3" from the other series made to apply against 0.16.... 

Given that the next major rygel update will be needed to build against next major gupnp versions and the patch series has already been applied there, I guess we can just close this bug as obsolete....
Comment 9 Jens Georg 2012-10-11 18:11:24 UTC
Well this only applies if building from vala, building the distributed tarball still works.