After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685327 - applet: suppress applet notifications when the Shell is running
applet: suppress applet notifications when the Shell is running
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 682418 684485 (view as bug list)
Depends on:
Blocks: 684823
 
 
Reported: 2012-10-02 20:20 UTC by Cosimo Cecchi
Modified: 2012-10-02 21:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
applet: suppress applet notifications when the Shell is running (815 bytes, patch)
2012-10-02 20:20 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-10-02 20:20:43 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2012-10-02 20:20:45 UTC 
Created attachment 225621 [details] [review]
applet: suppress applet notifications when the Shell is running
Comment 2 Cosimo Cecchi 2012-10-02 20:22:26 UTC 
Why does the applet still need to run at all in a non-fallback session though nowadays?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-02 20:30:27 UTC 
(In reply to comment #2)
> Why does the applet still need to run at all in a non-fallback session though
> nowadays?

It doesn't. I don't know why it's running.
Comment 4 Dan Williams 2012-10-02 20:35:42 UTC 
(In reply to comment #2)
> Why does the applet still need to run at all in a non-fallback session though
> nowadays?

I'm not sure if we've handled the 3G PIN entry case yet in the shell, but that's the last possible piece that nm-applet does that the shell doesn't do.  This is the feature where nm-applet listens for ModemManager D-Bus signals and sends a saved PIN code to ModemManager to unlock the modem whenever it's inserted, so that registration status and SMS work without having to manually turn the 3G device on.  People want to have their PIN code saved in the keyring and the device automatically unlocked on hotplug.

But yes, we need the applet for fallback.  No, Shell-only setups (like Fedora 18 where we'll always use LLVMpipe and never fallback-mode) do not need the applet if you can live without 3G PIN handling.  Or we can add that PIN thing to the Shell.  Or, we have been discussing on the mailing list, we enhance NM to have a concept of "device secrets" that are not tied to a connection, but are a property of the device itself (in this case the SIM card, really).

I don't think we can play games with Autostart= because the applet is used in XFCE and LXDE too.
Comment 5 Matthias Clasen 2012-10-02 20:37:27 UTC 
we can just do NotShowIn=GNOME, if nothing else
Comment 6 Dan Williams 2012-10-02 20:39:32 UTC 
Review of attachment 225621 [details] [review]:

looks good
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-10-02 20:40:15 UTC 
(In reply to comment #4)
> Or we can add that PIN thing to the Shell.

Fine with me, if really needed. Giovanni even made a PIN widget for the screen shield, and I'm not sure why it hasn't landed yet.
Comment 8 Cosimo Cecchi 2012-10-02 20:43:29 UTC 
Attachment 225621 [details] pushed as 05f975d - applet: suppress applet notifications when the Shell is running

Pushed this to master and nma-0-9-6. I'll close this as FIXED, will open a new bug for the Shell PIN part.
Comment 9 Cosimo Cecchi 2012-10-02 21:36:23 UTC 
*** Bug 684485 has been marked as a duplicate of this bug. ***
Comment 10 Cosimo Cecchi 2012-10-02 21:37:30 UTC 
*** Bug 682418 has been marked as a duplicate of this bug. ***