GNOME Bugzilla – Bug 684823
"Activation of network connection failed" for user-canceled operations
Last modified: 2012-12-03 18:03:31 UTC
To reproduce: - select a protected wireless in range from the network menu, for which no secrets are saved in the session yet - at the password prompt press Cancel - you'll get an "Activation of network connection failed" notification The use of this notification is unnecessary; since the user manually canceled the password dialog just one instant before, the notification is just extra noise.
"This problem" is commented in the code indirectly. In the code: " // XXX: nm-applet has no special text depending on reason // but I'm not sure of this generic message " The problem is that nm-applet launch a NM_DEVICE_STATE_REASON_NO_SECRETS when we cancel. And this can be caused for cancel the dialog or for other reasons. So we can discern between "reasons". I think that we have to file a bug against nm-applet. Can someone confirm this?
I can confirm it partially, in the sense that yes, we can discern based on the reason, but no, nm-applet is not at all involved in those notifications (and indeed, it should not be running at all in a non fallback session). I'll prepare a patch.
Created attachment 225611 [details] [review] NetworkMenu: don't notify for failed connections if cancelled by the user If the user cancels the secret dialog, the NM will report the connection failure, but we should not notify it as it is a user-initiated action.
Thanks Giovanni for the patch.
I tested the patch, and it indeed suppresses the Shell notification. I still seem to get another kind of notification, probably from nm-applet, with a non-symbolic icon; I get both that and the shell one without the patch though, so I think this is good to apply.
I filed https://bugzilla.gnome.org/show_bug.cgi?id=685327 for network-manager-applet. Why does the applet need to run at all in a non-fallback session though?
(In reply to comment #5) > I tested the patch, and it indeed suppresses the Shell notification. > I still seem to get another kind of notification, probably from nm-applet, with > a non-symbolic icon; I get both that and the shell one without the patch > though, so I think this is good to apply. Uhm... does that count as a review?
would be nice to get this in for 3.6.1
(In reply to comment #7) > Uhm... does that count as a review? I don't know that code, so probably not, but it fixes the bug.
Bah, nobody complained, let's get this in... Attachment 225611 [details] pushed as 6b1e632 - NetworkMenu: don't notify for failed connections if cancelled by the user