After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684537 - Do not use deprecated API
Do not use deprecated API
Status: RESOLVED DUPLICATE of bug 664524
Product: system-monitor
Classification: Core
Component: general
3.5.x
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-21 09:47 UTC by Stefano Facchini
Modified: 2012-09-23 21:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not use deprecated API (20.76 KB, patch)
2012-09-21 09:47 UTC, Stefano Facchini 		needs-work Details | Review
Do not use deprecated API (20.67 KB, patch)
2012-09-23 12:12 UTC, Stefano Facchini 		none Details | Review
Do not use deprecated API (20.71 KB, patch)
2012-09-23 21:02 UTC, Stefano Facchini 		none Details | Review

Description Stefano Facchini 2012-09-21 09:47:21 UTC 
Applies on top of patch attached to bug 684536
Comment 1 Stefano Facchini 2012-09-21 09:47:25 UTC 
Created attachment 224914 [details] [review]
Do not use deprecated API

Namely, we make the following replacements:
  * GtkStyle -> GtkStyleContext
  * GdkColor -> GdkRGBA
  * GtkColorSelectionDialog -> GtkColorChooserDialog

Also, explicitly include librsvg/rsvg-cairo.h in gsm_color_button.c
Comment 2 Robert Roth 2012-09-22 21:21:49 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 664524 ***
Comment 3 Robert Roth 2012-09-22 21:26:08 UTC 
Review of attachment 224914 [details] [review]:

Nice work. I have marked the bug as a duplicate of bug 664524 (build system monitor without warnings) as similar work has been started there. Your patch however seems a lot better than my branch linked there, so I like it, however it creates another warning in the build process : 
In file included from gsm_color_button.c:35:0:
/usr/include/librsvg-2.0/librsvg/rsvg-cairo.h:27:2: warning: #warning "Including <librsvg/rsvg-cairo.h> directly is deprecated." [-Wcpp]
So I guess including rsvg-cairo.h explicitly is not a good idea, it's enough to include rsvg.h. With that minor change, it's likely that I'll accept it, as it works as expected.
Comment 4 Stefano Facchini 2012-09-23 12:12:17 UTC 
Created attachment 225020 [details] [review]
Do not use deprecated API

Namely, we make the following replacements:
  * GtkStyle -> GtkStyleContext
  * GdkColor -> GdkRGBA
  * GtkColorSelectionDialog -> GtkColorChooserDialog



Yeah sorry about rsvg-cairo.h inclusion, my bad. I was building against an
outdated version of librsvg.
Comment 5 Stefano Facchini 2012-09-23 21:02:46 UTC 
Created attachment 225036 [details] [review]
Do not use deprecated API

Namely, we make the following replacements:
  * GtkStyle -> GtkStyleContext
  * GdkColor -> GdkRGBA
  * GtkColorSelectionDialog -> GtkColorChooserDialog



---
I forgot to change highlight_factor type from int to double
Comment 6 André Klapper 2012-09-23 21:12:22 UTC 
Not sure if attaching patches to an already closed report is the best way forward. Doing this in bug 664524 might be better?