GNOME Bugzilla – Bug 664524
System-monitor should build without warnings
Last modified: 2012-11-30 11:56:03 UTC
There are a few warnings during compilation besides the ones caused by the deprecated gtk?box and gtktable widgets. A clean build should be the goal.
Created attachment 205786 [details] [review] First proposed patch This patch updates the deprecated rsvg_handle_unref call to g_object_unref. Also refactored util.cpp cellrenderer functions to avoid code duplication.
Review of attachment 205786 [details] [review]: This looks like it should be 2 different patches.
@Chris: Could you please check if with the current master you still get any warnings, as I don't anymore, so this might be a good candidate to mark as fixed.
Created attachment 220093 [details] [review] Proposed patch Found a warning on 64 bit systems only (no warning on 32 bit systems) about incorrect conversion from gint to gpointer (gpointer is 64 bits long on a 64 bit system, but 32 bit on 32 bit systems, while gint is always 32 bits, I guess.) using the GINT_TO_GPOINTER glib macro
I still get a number of warning about the color picker api being deprecated. So, not qiute out of the woods yet.
OK, found that, color_selection dialog has been deprecated in 3.5, and I'm still at 3.4, and did not manage to install Arch linux yet to test the latest. Regardless, I have migrated the color selection dialog to color chooser, gdkcolor to gdkrgba, you can see that on my deprecations branch. The only problem I can see is that on System Monitor startup the colorbuttons are not correctly colored, they only appear as colored after the first color selection. I could not figure out why on startup these do not get initialized properly. @Chris: Could you please take a look when you have the time to see if you can find why this doesn't work. [1] http://git.gnome.org/browse/gnome-system-monitor/log/?h=deprecations
*** Bug 684537 has been marked as a duplicate of this bug. ***
Created attachment 225026 [details] [review] Fix automake warnings
(In reply to comment #8) > Created an attachment (id=225026) [details] [review] > Fix automake warnings note 1: There are still some warnings but it seems to me they are generated by AM_GNU_GETTEXT which is still using deprecated macros note 2: I removed the per-target macros in src/Makefile.am since we are only building one program. This fixes the "please use AM_PROG_CC_C_O" warning. Of course, if you feel it's better to keep the build system per-target, I'll add AM_PROG_CC_C_O :)
Created attachment 225039 [details] [review] Do not use deprecated API Namely, we make the following replacements: * GtkStyle -> GtkStyleContext * GdkColor -> GdkRGBA * GtkColorSelectionDialog -> GtkColorChooserDialog https://bugzilla.gnome.org/show_bug.cgi?id=684537
Review of attachment 225039 [details] [review]: Nice, works as expected, committed to master.
System monitor builds without warnings, so I am closing this.