After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684438 - Polkit modal prompts should have spinner while checking
Polkit modal prompts should have spinner while checking
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.6.1
Depends on:
Blocks:
 
 
Reported: 2012-09-20 08:54 UTC by Stef Walter
Modified: 2013-05-09 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
components: Disable prompt buttons while 'checking' password (3.71 KB, patch)
2012-09-20 09:01 UTC, Stef Walter
none Details | Review
components: Allow cancelling of dialog between prompts (4.46 KB, patch)
2012-10-12 19:36 UTC, Stef Walter
none Details | Review
modalDialog: Show spinner when working (11.20 KB, patch)
2013-04-17 10:23 UTC, Stef Walter
none Details | Review
modalDialog: Show spinner when working (15.18 KB, patch)
2013-04-17 11:04 UTC, Stef Walter
none Details | Review
modalDialog: Show spinner when working (15.10 KB, patch)
2013-04-17 11:28 UTC, Stef Walter
committed Details | Review

Description Stef Walter 2012-09-20 08:54:31 UTC
When a polkit (or other password prompt) is shown, often after the user clicks 'Authenticate' the prompt remains shown for a while if the password is invalid.

During this 'checking' state the prompt should reflect this and not remain sensitive. 

It could:

 * Disable the controls visibly somehow.
     and/or
 * Display a spinner icon animation indicating that processing is occurring.

... or something else altogether, pending designer input.
Comment 1 Stef Walter 2012-09-20 08:59:57 UTC
About hiding the prompt while checking the password: Even if this checking state becomes imperceptibly short (which it is for keyring, and which I think it should be for polkit) then you still want to avoid interleaving multiple prompts somehow. So the prompt shouldn't be hidden while checking, only to redisplay the same prompt less than a second later.

In some cases, such as the evolution password prompt (which I'm not sure should be system modal, in any case) the prompt should be hidden because the password checking attempt can take an arbitrarily long time. See bug #684433.

Also the Polkit prompt should allow reentering the password. That's a separate bug #684431.
Comment 2 Stef Walter 2012-09-20 09:01:32 UTC
Created attachment 224815 [details] [review]
components: Disable prompt buttons while 'checking' password

This is a temporary work around for this issue, since it's causing
user problems. See bug #682830.

While checking a password in either polkit or keyring prompts disable
the buttons during the check. This indicates to the user that input
is not possible.
Comment 3 Stef Walter 2012-09-21 08:43:45 UTC
Comment on attachment 224815 [details] [review]
components: Disable prompt buttons while 'checking' password

The patch needs a bit more work (but my git master gnome isn't working today):

 * Split the patch for polkit and the keyring prompts.
 * The keyring prompts should support cancellation while 'checking', see bug #678611.
Comment 4 Stef Walter 2012-10-12 19:36:06 UTC
Created attachment 226350 [details] [review]
components: Allow cancelling of dialog between prompts

Some callers of the keyring prompt keep the dialog up while
processing the prompt. Allow the user to cancel the prompt
while in this state.

This is propagated to the caller, who can cancel the operation
in question when this occurs.
Comment 5 Stef Walter 2012-10-12 19:36:35 UTC
Comment on attachment 224815 [details] [review]
components: Disable prompt buttons while 'checking' password

Implemented needs-work stuff as a separate patch.
Comment 6 Stef Walter 2013-04-17 10:18:26 UTC
Comment on attachment 224815 [details] [review]
components: Disable prompt buttons while 'checking' password

This patch has been partly done elsewhere, and last loose ends completed by patch on bug #696304.
Comment 7 Stef Walter 2013-04-17 10:23:12 UTC
Created attachment 241724 [details] [review]
modalDialog: Show spinner when working

Use the same UI concept from the login screen to show spinners when
the polkit or keyring dialogs are working
Comment 8 Stef Walter 2013-04-17 11:04:47 UTC
Created attachment 241726 [details] [review]
modalDialog: Show spinner when working

Use the same UI concept from the login screen to show spinners when
the polkit or keyring dialogs are working
Comment 9 Stef Walter 2013-04-17 11:28:27 UTC
Created attachment 241728 [details] [review]
modalDialog: Show spinner when working

Use the same UI concept from the login screen to show spinners when
the polkit or keyring dialogs are working
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-05-09 00:57:57 UTC
Review of attachment 241728 [details] [review]:

OK.

At some point we really should clean up the minute differences between the password dialogs, but that's a cleanup for later.
Comment 11 Jasper St. Pierre (not reading bugmail) 2013-05-09 00:59:28 UTC
Review of attachment 241728 [details] [review]:

OK.

At some point we really should clean up the minute differences between the password dialogs, but that's a cleanup for later.
Comment 12 Matthias Clasen 2013-05-09 10:44:28 UTC
Should we get these improvements into 3.8.2 ?
Comment 13 Stef Walter 2013-05-09 15:38:37 UTC
Attachment 241728 [details] pushed as 046a1a7 - modalDialog: Show spinner when working