After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696304 - Can't create a new keyring with empty password
Can't create a new keyring with empty password
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 699243 699944 700245 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-21 16:22 UTC by Vitezslav Humpa
Modified: 2014-01-03 04:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disabled "Continue" button (938.12 KB, image/png)
2013-04-10 13:44 UTC, Júlio Dutra 		  Details
keyring: Fix button disabled when prompting for confirmation (1.03 KB, patch)
2013-04-17 10:02 UTC, Stef Walter 		none Details | Review
keyring: Fix button disabled when prompting for confirmation (1.20 KB, patch)
2013-04-17 10:17 UTC, Stef Walter 		committed Details | Review

Description Vitezslav Humpa 2013-03-21 16:22:03 UTC 
On an attempt to use and create the keyring on first access, if an empty or super simple password (like '1234') is chosen the dialog box requesting confirmation comes: 'Store password unencrypted?'. However the 'Continue' button is disabled and one can't move forward. We should either be prohibited to use this password with a denial message or be allowed to do so.

gnome-keyring-3.7.92
Distro: Fedora 19 Alpha
Comment 1 Stef Walter 2013-03-22 08:52:36 UTC 
Cannot duplicate here. Could you include a screenshot so I can see which prompt you're referring to?
Comment 2 Júlio Dutra 2013-04-10 13:44:33 UTC 
Created attachment 241153 [details]
Disabled "Continue" button

Trying to set blank password for a keyring.
Comment 3 Vadim Rutkovsky 2013-04-12 10:35:33 UTC 
Reproduced on gnome-keyring-3.8.0-1.fc20.x86_64
Comment 4 Stef Walter 2013-04-17 10:02:00 UTC 
This is due to this:

    JS ERROR: !!!   Exception was: TypeError: this._passwordEntry is null
    JS ERROR: !!!     message = '"this._passwordEntry is null"'
    JS ERROR: !!!     fileName = '"/usr/share/gnome-shell/js/ui/components/keyring.js"'
    JS ERROR: !!!     lineNumber = '152'
    JS ERROR: !!!     stack = '"(true)@/usr/share/gnome-shell/js/ui/components/keyring.js:152
wrapper(true)@/usr/share/gjs-1.0/lang.js:213
([object GObject_Object])@/usr/share/gnome-shell/js/ui/components/keyring.js:188
wrapper([object GObject_Object])@/usr/share/gjs-1.0/lang.js:213
"'
Comment 5 Stef Walter 2013-04-17 10:02:58 UTC 
Created attachment 241721 [details] [review]
keyring: Fix button disabled when prompting for confirmation
Comment 6 Stef Walter 2013-04-17 10:17:21 UTC 
Created attachment 241722 [details] [review]
keyring: Fix button disabled when prompting for confirmation
Comment 7 Stef Walter 2013-05-08 18:11:37 UTC 
*** Bug 699944 has been marked as a duplicate of this bug. ***
Comment 8 Igor Gnatenko 2013-05-08 19:33:41 UTC 
(In reply to comment #6)
> Created an attachment (id=241722) [details] [review]
> keyring: Fix button disabled when prompting for confirmation
Yeah! You patch works!
Can you add it into upstream ?
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-05-08 19:40:41 UTC 
Review of attachment 241722 [details] [review]:

OK.
Comment 10 Stef Walter 2013-05-08 20:17:05 UTC 
Attachment 241722 [details] pushed as 30e9a2a - keyring: Fix button disabled when prompting for confirmation

Pushed to gnome-3-8, will push to master shortly.
Comment 11 Igor Gnatenko 2013-05-09 08:52:47 UTC 
(In reply to comment #10)
> Attachment 241722 [details] pushed as 30e9a2a - keyring: Fix button disabled when
> prompting for confirmation
> 
> Pushed to gnome-3-8, will push to master shortly.
I very badly know how it works. This patch will get in 3.8.2?
Comment 12 Florian Müllner 2013-05-09 09:40:04 UTC 
3.8.2 will be released from the gnome-3-8 branch, so yes.
Comment 13 Stef Walter 2013-05-13 19:09:11 UTC 
*** Bug 700245 has been marked as a duplicate of this bug. ***
Comment 14 Stef Walter 2013-06-18 14:21:11 UTC 
*** Bug 699243 has been marked as a duplicate of this bug. ***
Comment 15 Orgad Shaneh 2014-01-03 04:18:42 UTC 
It still doesn't work for me on debian (with 3.8.2). Any ideas?