After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683881 - Sorting by Date
Sorting by Date
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Register
2.4.x
Other Windows
: Normal enhancement
: ---
Assigned To: gnucash-ui-maint
Geert Janssens
: 106253 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-12 16:19 UTC by Luigi Puzziferro
Modified: 2018-06-29 23:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implement reverse transaction sorting (11.70 KB, patch)
2012-09-13 15:34 UTC, Mike Evans
rejected Details | Review

Description Luigi Puzziferro 2012-09-12 16:19:53 UTC
Would it be possible to allow the option when sorting by date to change the order? Oldest first or Newest first. My bank online account info which I use to confirm my balances etc sorts in the opposite order of GnuCash making it more difficult to do a side by side comparison.
Thanks for listening!
Comment 1 Mike Evans 2012-09-13 15:34:25 UTC
Created attachment 224233 [details] [review]
Implement reverse transaction sorting

My bank's web page also displays transaction in reverse order.

This implements reverse sorting but it has a small bug.  When transactions are reverse sorted the new/blank transaction is still at the bottom of the screen instead of at the top.

Patch is for review while I try to fix blank transaction issue.  All help welcome.
Comment 2 Luigi Puzziferro 2012-09-13 15:41:47 UTC
Mike
I have no idea how to use the attachment file. Can you walk me through it?
Luigi
Comment 3 Mike Evans 2012-09-13 18:25:56 UTC
(In reply to comment #2)
> Mike
> I have no idea how to use the attachment file. Can you walk me through it?
> Luigi

Unless you have the source files and a compiler it's of no use to you all I'm afraid.  I'm also a Linux user so I can't help with compiling on Windoze anyway. It's intended for other developers to apply to their source code copies, test and provide feedback.
Comment 4 Luigi Puzziferro 2012-09-13 19:55:57 UTC
Mike
I have no idea how to use the attachment file. Can you walk me through it?
Luigi
Comment 5 Luigi Puzziferro 2012-09-13 19:57:10 UTC
so is this something that will likely be integrated into the next update of GnuCash?
Comment 6 Mike Evans 2012-09-13 20:35:33 UTC
(In reply to comment #5)
> so is this something that will likely be integrated into the next update of
> GnuCash?

Hopefully, yes.
Comment 7 Geert Janssens 2012-09-19 20:41:43 UTC
Review of attachment 224233 [details] [review]:

Looks good so far. As you say, it would be more useful if the new transaction appears on top with reversed sort order, but that's not an absolute must. It can also be added later.

On thing I was missing is the option to save the reverse setting. No matter whether or not the "Save sort order" is checked or not, the reverse setting is never saved/restored. The other options are.
Comment 8 Mike Evans 2012-09-20 10:47:25 UTC
Thanks for reviewing the patch Geert.  I didn't get around to implementing the save because I got sidetracked looking at how to make the blank_split appear at the top when reverse order is selected.  Still haven't found how to do that.  Pointers welcome, but as you say it could be implemented later.
Comment 9 Mike Evans 2013-02-08 10:42:39 UTC
Comment on attachment 224233 [details] [review]
Implement reverse transaction sorting

This patch has been made obsolete by later commits.
Comment 10 Mike Evans 2013-02-08 11:06:39 UTC
Committed to trunk as r22766, 2a514adf0f8

Leaving this bug open as this is still not complete.
Comment 11 Mike Evans 2013-02-08 11:12:11 UTC
Ah, git commit hash should be  679d59e44
Comment 12 John Ralls 2013-11-30 19:26:11 UTC
Is this being held open for some reason?
Comment 13 Mike Evans 2013-12-01 09:23:12 UTC
Only because I never implmented the save and getting the blank_split at the to top of the page when reverse sorting is active.  These could be a new bug I guess. I stopped because register2 would have made all this redundant.

Reverse sorting needs adding to the documentation too.
Comment 14 Mike Evans 2014-05-09 08:40:09 UTC
*** Bug 106253 has been marked as a duplicate of this bug. ***
Comment 15 Geert Janssens 2015-10-10 17:12:36 UTC
Review of attachment 224233 [details] [review]:

Made obsolete by a newer patch. I'm changing the state to drop this attachment from bugzilla searches on attachments with state "reviewed"
Comment 16 Geert Janssens 2016-08-24 10:03:41 UTC
(In reply to Mike Evans from comment #13)
> Only because I never implmented the save and getting the blank_split at the
> to top of the page when reverse sorting is active.  These could be a new bug
> I guess. I stopped because register2 would have made all this redundant.
> 
> Reverse sorting needs adding to the documentation too.

Saving the reverse sort order is the topic of bug 770136 which I have just fixed for gnucash 2.6.14. Remains only to get the blank split at the top and the documentation. I'm not sure the first part is still worth pursuing. The documentation obviously is.
Comment 17 Mike Evans 2016-08-25 08:59:21 UTC
Cheers Geert. 

I guess I can close this bug as it's original requirement has been fulfilled.

Documentation and the blank split should be new separate bug. I'll open a bug for documentation.

Mike
Comment 18 John Ralls 2017-09-24 22:47:55 UTC
Reassign version to 2.4.x so that individual 2.4 versions can be retired.
Comment 19 John Ralls 2018-06-29 23:10:30 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=683881. Please update any external references or bookmarks.