After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682752 - Inaccurate calculations create desynch offsetting in the ruler with decimal framerates
Inaccurate calculations create desynch offsetting in the ruler with decimal f...
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: 0.91
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-26 23:54 UTC by Jean-François Fortin Tam
Modified: 2012-09-02 04:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2012-08-26 23:54:46 UTC
Frame markers on the ruler canvas are not actually accurate.

I have proved that in my "framestepping-pygi" branch (derived from an old patch in bug #573895):
1- load a project with my various clips
2- set the project settings' framerate to 23.976, zoom in fully
3- framestep between frames, then move further to the right in the timeline and you'll notice it's off sync from the blue keyframe markers when you click and press the framestepping keys again.

From checking with a simple calculator and a debug statement I put in the stepFrame method, the algorithm of stepFrame is correct... Also, when hovering over the timeline ruler, the tooltip confirms that stepFrame is correct and that the ruler representation is wrong.

The reason is, among other things, that the ruler uses relative paint positions instead of using absolute positions, and adds some small offset errors everytime.
Comment 1 Jean-François Fortin Tam 2012-08-27 02:25:26 UTC
René thought of a fix for this, it's sitting in my pygi branch.
Comment 2 Jean-François Fortin Tam 2012-09-02 04:30:43 UTC
commit e6e210b0552a3da97588653a9653b5f7b72bf481
Author: René Stadler <mail@renestadler.de>
Date:   Sun Aug 26 16:56:23 2012 -0700

    ruler: Fix frame boundaries painting
    
    Fixes bug #682752