After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573895 - Frame-stepping not re-implemented
Frame-stepping not re-implemented
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal normal
: 0.91
Assigned To: Jean-François Fortin Tam
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-03 10:20 UTC by Edward Hervey
Modified: 2012-09-02 04:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to implement basic frame-stepping (4.71 KB, patch)
2011-04-06 16:42 UTC, David Jordan
none Details | Review

Description Edward Hervey 2009-03-03 10:20:36 UTC
We previously were able to do frame-stepping in the Viewer, but we can't anymore. This needs to be re-implemented.
Comment 1 Brandon Lewis 2009-12-17 22:46:53 UTC
has support for variable speed playback been merged yet? can we take advantage of that in pitivi?
Comment 2 Edward Hervey 2009-12-18 07:46:47 UTC
The frame-step seeking [1] has been in core since 0.10.24. All the work is done in core, so it doesn't involve anything specific to be implemented in plugins... for forward stepping.

For backward stepping, it will only work for demuxer/decoders that support negative-rate-seeking.


1: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstEvent.html#gst-event-new-step
Comment 3 David Jordan 2011-04-06 16:42:40 UTC
Created attachment 185332 [details] [review]
patch to implement basic frame-stepping
Comment 4 David Jordan 2011-04-06 16:43:12 UTC
I wrote a patch for implementing framestepping.  It's not ideal, since there are cases where it could be seeking by other than the project output framerate, but it does let you seek backward and forward in the timeline on a frame-by-frame basis.  I added buttons for seeking one frame in either direction to viewer.py and added a function to pipeline.py to seek forward or backward an arbitrary number of frames.
Comment 5 Jean-François Fortin Tam 2012-08-27 02:24:33 UTC
Okay, got a reworked and simplified version of this in my pygi branch, which should be merged to master sometime soon. I also have a fix for bug #682752.
Comment 6 Jean-François Fortin Tam 2012-09-02 04:28:51 UTC
Framestepping is now the default behavior of the left and right keys in pitivi master, mainly with commit d6006aa11.