After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681736 - Support both old and new-buf libxml2 APIs
Support both old and new-buf libxml2 APIs
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
unspecified
Other All
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-08-13 09:17 UTC by Stef Walter
Modified: 2012-08-13 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
caldav: Fix build because of libxml2 API breakage (1.13 KB, patch)
2012-08-13 09:17 UTC, Stef Walter
none Details | Review

Description Stef Walter 2012-08-13 09:17:49 UTC
Recently libxml2 broke API. See:

https://mail.gnome.org/archives/desktop-devel-list/2012-August/msg00004.html

The attached patch fixes the build, and works with both old
and new libxml2 versions. I know #ifdefs suck, and the solution
is far from elegant, but it looks like this is the recommended
way to fix the issue.
Comment 1 Stef Walter 2012-08-13 09:17:51 UTC
Created attachment 220978 [details] [review]
caldav: Fix build because of libxml2 API breakage

 * libxml2 introduced some API breakage recently.
 * Fix the build so it works with both old and new versions
   of libxml2.
Comment 2 Matthew Barnes 2012-08-13 14:56:51 UTC
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.

*** This bug has been marked as a duplicate of bug 681321 ***
Comment 3 Matthew Barnes 2012-08-13 14:57:26 UTC
Oh, whoops.  Not a dupe.  This is for Evolution.
Comment 4 Matthew Barnes 2012-08-13 15:43:18 UTC
Thanks for the patch.  I think I'm going to reuse Colin's "compat" function from bug 681321 to keep the #ifdef crud isolated from the main code.

Fixed for Evolution 3.5.90 in:
http://git.gnome.org/browse/evolution/commit/?id=ff88d1f11176233438cace72da46a54c479495ab