After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681321 - Support both old and new-buf libxml2 APIs
Support both old and new-buf libxml2 APIs
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.6.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-08-06 17:11 UTC by Colin Walters
Modified: 2013-09-14 16:55 UTC
See Also:
GNOME target: 3.6
GNOME version: ---

Attachments
Support both old and new-buf libxml2 APIs (6.48 KB, patch)
2012-08-06 17:11 UTC, Colin Walters 		none Details | Review
Support both old and new-buf libxml2 APIs (6.50 KB, patch)
2012-08-06 19:20 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-08-06 17:11:52 UTC 
libxml2 changed the API for xmlOutputBuffer incompatibly;
See https://mail.gnome.org/archives/desktop-devel-list/2012-August/msg00004.html
Comment 1 Colin Walters 2012-08-06 17:11:53 UTC 
Created attachment 220479 [details] [review]
Support both old and new-buf libxml2 APIs
Comment 2 Colin Walters 2012-08-06 17:12:09 UTC 
Note: Only compile tested.
Comment 3 Colin Walters 2012-08-06 19:20:09 UTC 
Created attachment 220489 [details] [review]
Support both old and new-buf libxml2 APIs

Now using directly xmlOutputBufferGet*() APIs
Comment 4 Matthew Barnes 2012-08-06 20:58:02 UTC 
Probably worth examining whether the backend really needs to be (ab)using the xmlOutputBuffer struct like that or if it was just convenient at the time for a lazy developer.
Comment 5 Daniel Veillard 2012-08-07 14:42:02 UTC 
Okay provided patch looks just fine to me, that should work !

w.r.t. comment #4 well I think I didn't gave proper directions
on how to use xmlOutputBuffers, so that use isn't a shame, I
would have given accessors from the start if I had found that
it woud be used in that way. With the patch it's not that bad frankly

Daniel
Comment 6 Stef Walter 2012-08-13 06:29:34 UTC 
Matthew, this is breaking GNOME the build. Unless there are serious objections, we should probably merge the patch and do any needed refactoring later while not blocking others, no?
Comment 7 Matthew Barnes 2012-08-13 14:55:31 UTC 
If it's good enough for Daniel it's good enough for me.

Fixed for Evolution-Data-Server 3.5.90:
http://git.gnome.org/browse/evolution-data-server/commit/?id=679b10d75730e81fa268e11cfda289a27fd3e306
Comment 8 Matthew Barnes 2012-08-13 14:56:51 UTC 
*** Bug 681736 has been marked as a duplicate of this bug. ***
Comment 9 Stef Walter 2012-08-13 14:57:03 UTC 
Thanks!