After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681121 - gnutls: port GTlsFileDatabaseGnutls to GBytes
gnutls: port GTlsFileDatabaseGnutls to GBytes
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on: 680912 681319
Blocks: 681122
 
 
Reported: 2012-08-03 09:50 UTC by Stef Walter
Modified: 2012-08-06 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnutls: port GTlsFileDatabaseGnutls to GBytes (14.19 KB, patch)
2012-08-03 09:50 UTC, Stef Walter 		needs-work Details | Review
gnutls: port GTlsFileDatabaseGnutls to GBytes (14.17 KB, patch)
2012-08-06 17:06 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-08-03 09:50:08 UTC 
 * Instead of GByteArray, where possible
Comment 1 Stef Walter 2012-08-03 09:50:10 UTC 
Created attachment 220220 [details] [review]
gnutls: port GTlsFileDatabaseGnutls to GBytes
Comment 2 Dan Winship 2012-08-03 14:55:34 UTC 
Comment on attachment 220220 [details] [review]
gnutls: port GTlsFileDatabaseGnutls to GBytes

>+  g_object_get (cert, "certificate", &array, NULL);
>+  g_return_val_if_fail (array, NULL);
>+  return g_byte_array_free_to_bytes (array);

as in the other patch, you can't do that. (Well, I guess you can, since you know it's a GTlsCertificateGnutls, but you shouldn't anyway.)

Maybe add "certificate-bytes" and "private-key-bytes" properties to GTlsCertificate?
Comment 3 Stef Walter 2012-08-06 17:06:21 UTC 
Created attachment 220477 [details] [review]
gnutls: port GTlsFileDatabaseGnutls to GBytes

 * Instead of GByteArray, where possible
Comment 4 Stef Walter 2012-08-06 20:40:01 UTC 
Attachment 220477 [details] pushed as c63f079 - gnutls: port GTlsFileDatabaseGnutls to GBytes