After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680912 - gchecksum: Add g_compute_checksum_for_bytes()
gchecksum: Add g_compute_checksum_for_bytes()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on: 681151
Blocks: 681121
 
 
Reported: 2012-07-31 14:49 UTC by Stef Walter
Modified: 2012-08-06 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gchecksum: Add g_compute_checksum_for_bytes() (2.46 KB, patch)
2012-07-31 14:49 UTC, Stef Walter 		reviewed Details | Review
gchecksum: Add g_compute_checksum_for_bytes() (3.21 KB, patch)
2012-07-31 15:14 UTC, Stef Walter 		none Details | Review
gchecksum: Add g_compute_checksum_for_bytes() (6.35 KB, patch)
2012-08-03 16:25 UTC, Stef Walter 		none Details | Review
gchecksum: Add g_compute_checksum_for_bytes() (6.40 KB, patch)
2012-08-03 16:32 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-07-31 14:49:31 UTC 
Add a GBytes version of g_compute_checksum_for_data()
Comment 1 Stef Walter 2012-07-31 14:49:33 UTC 
Created attachment 219986 [details] [review]
gchecksum: Add g_compute_checksum_for_bytes()

 * Add a GBytes based version of g_compute_checksum_for_data()
Comment 2 Colin Walters 2012-07-31 15:06:01 UTC 
Review of attachment 219986 [details] [review]:

Add a test?
Comment 3 Stef Walter 2012-07-31 15:14:37 UTC 
Created attachment 219989 [details] [review]
gchecksum: Add g_compute_checksum_for_bytes()

* Add a GBytes based version of g_compute_checksum_for_data()
Comment 4 Dan Winship 2012-08-03 14:48:12 UTC 
Comment on attachment 219989 [details] [review]
gchecksum: Add g_compute_checksum_for_bytes()


> 
>+gchar                *g_compute_checksum_for_bytes  (GChecksumType    checksum_type,

prefix that with

GLIB_AVAILABLE_IN_2_34


also, this still doesn't include a test? did you attach the wrong patch?
Comment 5 Stef Walter 2012-08-03 16:25:32 UTC 
Created attachment 220263 [details] [review]
gchecksum: Add g_compute_checksum_for_bytes()

* Add a GBytes based version of g_compute_checksum_for_data()

Added tests for new g_compute_checksum_for_bytes() as requested.
Comment 6 Stef Walter 2012-08-03 16:32:58 UTC 
Created attachment 220265 [details] [review]
gchecksum: Add g_compute_checksum_for_bytes()

Added the GLIB_AVAILABLE_IN_2_34  directive.
Comment 7 Matthias Clasen 2012-08-04 17:54:30 UTC 
Review of attachment 220265 [details] [review]:

Looks ok now.
Comment 8 Stef Walter 2012-08-06 08:42:13 UTC 
Attachment 220265 [details] pushed as 278fe0c - gchecksum: Add g_compute_checksum_for_bytes()