GNOME Bugzilla – Bug 680985
improve the view / page menu
Last modified: 2012-08-17 01:05:51 UTC
Created attachment 220063 [details] mockup Currently our view / page menu is a bit of a placeholder. We should improve it. We spent some time on this at the UX Hackfest last week.
*** Bug 680567 has been marked as a duplicate of this bug. ***
[Copying GNOME target from 680567.]
Thanks for posting the mockup. It's clearly an improvement over what we have today and I believe I really like it! One concern that I have is accessibility. How would someone access the view drop-down menu via keyboard? Would Alt+V (in English) be appropriate? How would a blind user of GNOME 3.4 know how to navigate the menus in Nautilus 3.6 after upgrading? Since now there are 3 different drop-down menus and the traditional Alt or Alt+F won't do anything. Please let me know if I should instead open a new bug. Thanks! I also wonder whether the Sidebar option would be better placed in the view menu.
Thanks for the mockup; I am not sure whether I understand everything correctly, so here is how I am interpreting it: - the black menu is the gear menu - the white menu at the right of the gear menu is the the view menu and it gets opened the downwards pointing arrow. - the three context menus in the bottom row are also clear - unfortunately, I am not sure about what to link the right white menu of the upper row to And now to the remarks: - I like the fact that the submenus have disappeared - the fact that the context menu adapts to the selected items might be welcome by some users; others might prefer the items remaining in the menus and being disabled; in any way, it is not possible to satisfy everybody; removing inappropriate items has at least the advantage of clearing it up - the Select All item could be available in all three context menus - the Duplicate item has disappeared and people might say that it is not a huge problem because it only was a shortcut for the two steps of copy followed by paste; this however is related to what is the most disturbing to me in the new mockup: What is disturbing me most in the mockup is the fact that the Cut, Copy and Paste items are only available in the context menu. Jeremy already addressed an accessibility issue for keyboard only users; there is another category of accessibility users, namely those using only the pointer and one button to control the computer. These users will have to resort to the indirect way that they have to do the right click in order to access the Cut, Copy and Paste items. Thus, the probably most used items are the ones they cannot directly access. This accessibility issue might be solved by doing what firefox is already offering to its users: in firefox it is possible to open the context menu in a page by a click and hold of the primary (left) mouse button. (it is not enabled by default in firefox) Could you please take into account to add the click and hold to nautilus as a gesture to open the context menu? This might also be welcome by touchscreen users as a replacement of the multiple finger gesture. @ William Jon McCann Do you think that the click and hold gesture to open the context menu is something you might be implemented in nautilus?
Created attachment 220677 [details] [review] Add a view menu button to the toolbar
Created attachment 220678 [details] [review] Move bookmarks to app menu and only show add bookmark in page menu
Created attachment 220679 [details] [review] Move enter location into the app menu
Created attachment 220680 [details] [review] Remove items from the gear menu that pertain to the selection We want the gear menu to pertain to the directory view and be relatively stable. We provide selection specific items in the context menu.
Created attachment 220690 [details] [review] Remove items from the gear menu that pertain to the selection We want the gear menu to pertain to the directory view and be relatively stable. We provide selection specific items in the context menu.
Created attachment 220726 [details] [review] Add view options directly to the toolbar Instead of having them buried in the menus.
Created attachment 220727 [details] [review] Add a view menu button to the toolbar
Created attachment 220728 [details] [review] Move bookmarks to app menu and only show add bookmark in page menu
Created attachment 220729 [details] [review] Move enter location into the app menu
Created attachment 220730 [details] [review] Remove items from the gear menu that pertain to the selection We want the gear menu to pertain to the directory view and be relatively stable. We provide selection specific items in the context menu.
Do you want me to create a separate bug against nautilus for opening the context menu with a press and hold? Apart firefox that is supporting it for quite some time, GNOME Shell also supports it in the activity window and there is also work to support a press-and-hold signal in gtk (I was not able to determine whether it has already gone stable). Thus, I assume that supporting the press and hold also in nautilus could be seen as making GNOME more consistent as a gesture available in GNOME Shell will also be available in nautilus.
Review of attachment 220726 [details] [review]: Looks good to me, with the following fixes ::: src/nautilus-window-menus.c @@ +654,3 @@ + gtk_action_set_accel_path (GTK_ACTION (action), "<Nautilus-Window>/View List"); + gtk_action_set_icon_name (GTK_ACTION (action), "view-list-symbolic"); + NULL, 0)); I don't think it's necessary to set the group to NULL here @@ +668,3 @@ + gtk_action_set_accel_path (GTK_ACTION (action), "<Nautilus-Window>/View Grid"); + gtk_radio_action_set_group (GTK_RADIO_ACTION (action), radio_group); + g_object_unref (action); This shouldn't be needed ::: src/nautilus-window.c @@ -1170,3 @@ -{ - g_list_free_full (window->details->short_list_viewers, g_free); - window->details->short_list_viewers = NULL; Can we also remove short_list_viewers and short_list_merge_id from the NautilusWindowPrivate struct now?
Review of attachment 220728 [details] [review]: Looks good
Review of attachment 220729 [details] [review]: Looks good
Review of attachment 220730 [details] [review]: Does removing actions such as Copy/Paste from the gear change anything for their keyboard shortcuts? Provided it doesn't, looks good. ::: src/nautilus-view.c @@ -4520,3 @@ - action_name, - GTK_UI_MANAGER_MENUITEM, - FALSE); Why did you remove this code? (not saying you shouldn't have, but I wonder what it was used for before).
Review of attachment 220727 [details] [review]: Patch looks good, but I can't find references to the renamed gear menu (ActionMenu) ::: src/nautilus-toolbar.c @@ +227,3 @@ tool_item = gtk_tool_item_new (); tool_button = toolbar_create_toolbutton (self, TRUE, FALSE, "emblem-system-symbolic"); + menu = gtk_ui_manager_get_widget (self->priv->ui_manager, "/ActionMenu"); Where is ActionMenu defined?
Review of attachment 220727 [details] [review]: ::: src/nautilus-toolbar.c @@ +227,3 @@ tool_item = gtk_tool_item_new (); tool_button = toolbar_create_toolbutton (self, TRUE, FALSE, "emblem-system-symbolic"); + menu = gtk_ui_manager_get_widget (self->priv->ui_manager, "/ActionMenu"); src/nautilus-shell-ui.xml
Review of attachment 220730 [details] [review]: ::: src/nautilus-view.c @@ -4520,3 @@ - action_name, - GTK_UI_MANAGER_MENUITEM, - FALSE); I think it was used for merging the open with items into the gear menu.
Review of attachment 220730 [details] [review]: Keyboard shortcuts for copy/paste etc still work.
Review of attachment 220730 [details] [review]: Okay, makes sense
Review of attachment 220727 [details] [review]: Oops, missed that :)
Attachment 220726 [details] pushed as 37a2fc4 - Add view options directly to the toolbar Attachment 220727 [details] pushed as 55420e1 - Add a view menu button to the toolbar Attachment 220728 [details] pushed as ac7318f - Move bookmarks to app menu and only show add bookmark in page menu Attachment 220729 [details] pushed as 5f5dd8a - Move enter location into the app menu Attachment 220730 [details] pushed as 6539e93 - Remove items from the gear menu that pertain to the selection
(In reply to comment #15) > Do you want me to create a separate bug against nautilus for opening the > context menu with a press and hold? Yes please.
Here is the separate bug for the press and hold feature: https://bugzilla.gnome.org/show_bug.cgi?id=681629 Thanks for taking it into account.
*** Bug 424887 has been marked as a duplicate of this bug. ***
*** Bug 682063 has been marked as a duplicate of this bug. ***