GNOME Bugzilla – Bug 679900
Awesomer search
Last modified: 2012-08-14 01:02:25 UTC
It would be nice to have an awesomer search. There are a few things we may be able to do. * Integrate the search and query editor bars to save space and make it easier to use and less disruptive when it comes up * Bring up the search when typing anything in the window * Make search faster * Allow a simpler way to select where to search
Created attachment 218769 [details] [review] Combine the search bar and query editor Save vertical space by integrating the search bar with the query editor. This makes it less visually disruptive when a search becomes active.
Created attachment 218770 [details] [review] Enable "just type" searching
Created attachment 218771 [details] [review] Interpret a blank search as a search for any name This allows us to filter the list based on other parameters like file type and to make clearing the search make more sense.
Created attachment 218772 [details] [review] Shorten the live search timeout value This makes search more responsive.
Created attachment 218783 [details] [review] Enable "just type" searching Remove all the unused code.
Review of attachment 218769 [details] [review]: Looks great, just a couple of minor things ::: src/nautilus-query-editor.c @@ +1099,3 @@ + gtk_button_set_label (GTK_BUTTON (editor->details->search_current_button), + name); + } else { You should unref the NautilusFile ::: src/nautilus-window-slot.c @@ +132,3 @@ + current query. */ + create_new_search (slot); + g_object_unref (location); I don't think it's correct to return here @@ +667,3 @@ + NautilusDirectory *directory; + + directory = nautilus_directory_get (slot->location); We're leaking the NautilusDirectory
Review of attachment 218771 [details] [review]: Looks good ::: src/nautilus-query-editor.c @@ +1075,3 @@ query_is_valid (NautilusQueryEditor *editor) { + return TRUE; Can we remove this function altogether? (not a blocker for merging it)
Review of attachment 218772 [details] [review]: Okay
Review of attachment 218783 [details] [review]: ::: src/nautilus-window-slot.c @@ +200,3 @@ + gtk_widget_hide (GTK_WIDGET (slot->query_editor)); + g_signal_handler_disconnect (slot->query_editor, slot->qe_changed_id); + g_signal_handler_disconnect (slot->query_editor, slot->qe_cancel_id); Are you sure this function is called always with alternating values for the visible parameter? ::: src/nautilus-window.c @@ +1508,3 @@ + if (nautilus_window_slot_handle_event (window->details->active_slot, event)) { + toggle_toolbar_search_button (window, TRUE); + handled = TRUE; You could follow the same style of the rest of the function and return TRUE here directly without using another variable.
Created attachment 218802 [details] [review] Combine the search bar and query editor Save vertical space by integrating the search bar with the query editor. This makes it less visually disruptive when a search becomes active.
Created attachment 218803 [details] [review] Enable "just type" searching
Created attachment 218804 [details] [review] Interpret a blank search as a search for any name This allows us to filter the list based on other parameters like file type and to make clearing the search make more sense.
Review of attachment 218802 [details] [review]: Looks good
Review of attachment 218803 [details] [review]: Looks good ::: src/nautilus-window.c @@ +1510,3 @@ + return TRUE; + } + event->keyval != GDK_KEY_Delete) { Can you remove the handled variable completely? It's always FALSE
Review of attachment 218804 [details] [review]: Looks good
The new search is cool, but replacing the previous type-ahead search to find and select stuff in the current view with the immediate recursive directory crawling is a bad idea. In a folder full of stuff, how do I quickly jump to a particular file or folder? I know there’s still Ctrl-S, this is not the same. I think tying type-ahead to the crawling search is a bad idea. Crawling is slow, and people are used to typing initial letters to scroll to and highlight what they are looking for.
(In reply to comment #16) > I think tying type-ahead to the crawling search is a bad idea. Crawling is > slow, and people are used to typing initial letters to scroll to and highlight > what they are looking for. True. Should we file a bug to report the fact that this essential feature is now broken?
Alex, cf. bug #680118
*** Bug 663211 has been marked as a duplicate of this bug. ***
*** Bug 42203 has been marked as a duplicate of this bug. ***