Created attachment 217610 [details] [review]
add empathy-subscription-dialog

This is copied from the similar dialog in empathy-account-dialogs.c which I'm
about to remove.

Created attachment 217611 [details] [review]
event-manager: use EmpathySubscriptionDialog

Created attachment 217612 [details] [review]
remove empathy_subscription_dialog_show()

Created attachment 217613 [details] [review]
inline block_contact_dialog_show() into subscription-dialog.c

It's only used there now.

Created attachment 217614 [details] [review]
individual-widget: don't display unknown presence

Best to to not show anything than showing we don't know.

Created attachment 217615 [details] [review]
inline block_contact_dialog_show() into subscription-dialog.c

It's only used there now.

Review of attachment 217611 [details] [review]:

::: src/empathy-event-manager.c
@@ +1071,3 @@
+
+  dialog = empathy_subscription_dialog_new (individual, event->public.message);
+  empathy_window_present (GTK_WINDOW (dialog));

gtk_wiondow_present() is enough AFAIK. The empathy_window_present is for extra workspace tricks for the contact list IIRC.

The rest looks good, +1

Thanks, fixing and merging.

Attachment 217610 [details] pushed as 875ec0d - add empathy-subscription-dialog
Attachment 217611 [details] pushed as b020c79 - event-manager: use EmpathySubscriptionDialog
Attachment 217612 [details] pushed as 001cd2e - remove empathy_subscription_dialog_show()
Attachment 217614 [details] pushed as 20a4ffc - individual-widget: don't display unknown presence
Attachment 217615 [details] pushed as 7615fb3 - inline block_contact_dialog_show() into subscription-dialog.c