After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679111 - Unify Contact/Individual API
Unify Contact/Individual API
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: 3.8
Assigned To: empathy-maint
empathy-maint
Depends on: 679136
Blocks:
 
 
Reported: 2012-06-29 09:01 UTC by Guillaume Desmottes
Modified: 2018-05-22 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
factor out empathy_display_individual_info() (10.25 KB, patch)
2012-07-11 09:03 UTC, Guillaume Desmottes
committed Details | Review
chat: use empathy_display_individual_info() (1.64 KB, patch)
2012-07-11 09:03 UTC, Guillaume Desmottes
committed Details | Review
contact-search-dialog: use empathy_display_individual_info() (1.71 KB, patch)
2012-07-11 09:03 UTC, Guillaume Desmottes
committed Details | Review
log-window: use empathy_display_individual_info() (1.49 KB, patch)
2012-07-11 09:03 UTC, Guillaume Desmottes
committed Details | Review
contact-dialogs: remove unused methods (4.12 KB, patch)
2012-07-11 09:03 UTC, Guillaume Desmottes
none Details | Review
individual-menu: use the individual version of the add dialog (1.68 KB, patch)
2012-07-11 09:36 UTC, Guillaume Desmottes
committed Details | Review
remove useless includes (1.85 KB, patch)
2012-07-11 09:36 UTC, Guillaume Desmottes
committed Details | Review
remove empathy-contact-dialogs (16.51 KB, patch)
2012-07-11 09:36 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2012-06-29 09:01:04 UTC
Atm some Empathy code is EmpathyContact oriented while newer code is FolksIndividual oriented. We should continue moving towards FolksIndividual and remove all duplicated code.
Comment 1 Guillaume Desmottes 2012-06-29 12:45:17 UTC
Subscription dialog: bug #679136
Comment 2 Guillaume Desmottes 2012-07-11 09:03:44 UTC
Created attachment 218501 [details] [review]
factor out empathy_display_individual_info()

It didn't want to put more misc stuffs to ui-utils so used this file.
Comment 3 Guillaume Desmottes 2012-07-11 09:03:47 UTC
Created attachment 218502 [details] [review]
chat: use empathy_display_individual_info()
Comment 4 Guillaume Desmottes 2012-07-11 09:03:50 UTC
Created attachment 218503 [details] [review]
contact-search-dialog: use empathy_display_individual_info()
Comment 5 Guillaume Desmottes 2012-07-11 09:03:53 UTC
Created attachment 218504 [details] [review]
log-window: use empathy_display_individual_info()
Comment 6 Guillaume Desmottes 2012-07-11 09:03:55 UTC
Created attachment 218505 [details] [review]
contact-dialogs: remove unused methods
Comment 7 Guillaume Desmottes 2012-07-11 09:36:49 UTC
Created attachment 218520 [details] [review]
individual-menu: use the individual version of the add dialog
Comment 8 Guillaume Desmottes 2012-07-11 09:36:52 UTC
Created attachment 218521 [details] [review]
remove useless includes
Comment 9 Guillaume Desmottes 2012-07-11 09:36:55 UTC
Created attachment 218522 [details] [review]
remove empathy-contact-dialogs
Comment 10 Xavier Claessens 2012-07-11 09:58:25 UTC
+1
Comment 11 Guillaume Desmottes 2012-07-11 10:00:59 UTC
Attachment 218501 [details] pushed as 60e19a5 - factor out empathy_display_individual_info()
Attachment 218502 [details] pushed as 3878f8c - chat: use empathy_display_individual_info()
Attachment 218503 [details] pushed as 634a85b - contact-search-dialog: use empathy_display_individual_info()
Attachment 218504 [details] pushed as 15b0acd - log-window: use empathy_display_individual_info()
Attachment 218520 [details] pushed as 791b7e8 - individual-menu: use the individual version of the add dialog
Attachment 218521 [details] pushed as 1d63b3b - remove useless includes
Attachment 218522 [details] pushed as 363703b - remove empathy-contact-dialogs
Comment 12 Guillaume Desmottes 2012-07-11 11:24:10 UTC
Next step is to get rid of EmpathyContactWidget.
Comment 13 GNOME Infrastructure Team 2018-05-22 15:37:03 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/565.