After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678624 - update_mouse_mode : code should not be reached
update_mouse_mode : code should not be reached
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-22 11:44 UTC by Christophe Fergeau
Modified: 2017-04-06 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
spice: do not get_display(0) before it is ready (1.54 KB, patch)
2012-06-22 11:46 UTC, Marc-Andre Lureau
committed Details | Review

Description Christophe Fergeau 2012-06-22 11:44:54 UTC
When clicking on a box, after it zooms I get:
"(gnome-boxes:7673): GSpice-WARNING **: (spice-widget.c:1548):update_mouse_mode : code should not be reached"
This is reproducible at will by going back to the collection view and reclicking on a VM
Looking at a backtrace, boxes is creating a SpiceDisplay object before the corresponding channel has been fully initialized by a server message.
Comment 1 Marc-Andre Lureau 2012-06-22 11:46:09 UTC
Created attachment 217018 [details] [review]
spice: do not get_display(0) before it is ready

Only when Boxes.Display::show() has been emitted are we allowed
to get_display(), which is also fine in DISPLAY and PROPERTIES
ui_state.
Comment 2 Christophe Fergeau 2012-06-22 14:22:36 UTC
This patch makes the warning go away for me.
Comment 3 Marc-Andre Lureau 2012-06-22 14:35:42 UTC
Attachment 217018 [details] pushed as 3139eb5 - spice: do not get_display(0) before it is ready
Comment 4 Felipe Borges 2017-04-05 12:29:21 UTC
I am experiencing the same issue lately.

Boxes-Message: machine.vala:209: display RHEL-7 3 disconnected

(gnome-boxes:16174): GSpice-WARNING **: (/home/fborges/jhbuild/checkout/spice-gtk-0.33/src/spice-widget.c:2360):update_mouse_mode: code should not be reached

building Boxes from master.
Comment 5 Felipe Borges 2017-04-06 09:30:31 UTC
I was pointed out that this is not the same issue. My issue causes the display to be disconnected. I filled another bug to track it down https://bugzilla.gnome.org/show_bug.cgi?id=780963