GNOME Bugzilla – Bug 780963
Boxes fails to connect to Spice display
Last modified: 2017-04-24 13:15:40 UTC
gnome-boxes built from master here (ce9aa75). Fedora 26. When I try to open a box, it gets disconnected and there's a warning saying: (gnome-boxes:28542): GSpice-WARNING **: (/home/fborges/jhbuild/checkout/spice-gtk-0.33/src/spice-widget.c:2360):update_mouse_mode: code should not be reached
do you have spice debug ?
(In reply to Pavel Grunt from comment #1) > do you have spice debug ? Yep. https://paste.gnome.org/pvrryovka I see that right before the update_mouse_mode warning there is (gnome-boxes:12075): GSpice-DEBUG: /home/fborges/jhbuild/checkout/spice-gtk-0.33/src/spice-widget.c:2341 mouse mode 0 Where mouse_mode should be 1 || 2 (server, client). I wonder what changed. I git blamed boxes' spice-display.vala code and also the the spice-gtk-0.33 spice-widget.c code and nothing related seem to have changed recently.
Is this working if you downgrade to Boxes from f25? or if you keep Boxes from f26 and downgrade spice-gtk? What about using GDK_BACKEND=x11 rather than wayland? (the last suggestion being a shot in the dark)
(In reply to Christophe Fergeau from comment #3) > Is this working if you downgrade to Boxes from f25? It even works with Boxes 3.24 (in f26). It doesn't work with it built from master under jhbuild. > What about using GDK_BACKEND=x11 rather > than wayland? (the last suggestion being a shot in the dark) Same result. Doesn't work either.
Pavel Grunt suggested me to post the xml dump of one of the boxes https://paste.gnome.org/pn9zjyc2z
(In reply to Felipe Borges from comment #4) > (In reply to Christophe Fergeau from comment #3) > > Is this working if you downgrade to Boxes from f25? > > It even works with Boxes 3.24 (in f26). It doesn't work with it built from > master under jhbuild. > Ah, I'd experiment with master built against a f26 system if that's possible, and with 3.24 built under jhbuild. Ie first try to figure out whether the problem is in gnome-boxes master, in your jhbuild deps, ...
I was able to reproduce using vala 0.36.1-1.fc26, distro-sync'ing to f25 version 0.34.2 fixed boxes for me... Command I use to reproduce (Suggested by fidencio): git clean -xfd ; ./autogen.sh --prefix=/home/pgrunt/dev && make -j && make install && /home/pgrunt/dev/bin/gnome-boxes
the changed behavior is in spice-display.vala:223 connect_it() 0.36 clears open_fd 0.34 does not change open_fd (correct behavior) bt for 0.36:
+ Trace 237352
one difference between them is use of g_simple_async_result_complete ()
Created attachment 350293 [details] [review] spice-session: Do not transfer open_fd() ownership Otherwise just one channel can connect
Review of attachment 350293 [details] [review]: Sure! It solves the issue for me.
Attachment 350293 [details] pushed as 3779c06 - spice-session: Do not transfer open_fd() ownership